Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

446 CI(pre-commit hooks husky) #454

Merged
merged 1 commit into from
May 15, 2024

Conversation

rc10house
Copy link
Contributor

#446 Adds pre-commit hooks for linting, formatting, building, and testing.

Copy link
Contributor

@EandrewJones EandrewJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: please squash into a single commit.

package.json Outdated Show resolved Hide resolved
@rc10house rc10house force-pushed the 446-CI_precommit_hooks_husky branch 2 times, most recently from 739be23 to f63b88d Compare May 14, 2024 01:50
@rc10house rc10house requested a review from EandrewJones May 14, 2024 01:51
@Jyyjy
Copy link
Contributor

Jyyjy commented May 14, 2024

Nit: please squash into a single commit.

Can always squash and merge via GitHub

@EandrewJones
Copy link
Contributor

Nit: please squash into a single commit.

Can always squash and merge via GitHub

Yes, but I dislike the messy comments it auto-generates that just append all the prior commits. I think squashing locally encourages a better write up for your commit message :)

package.json Outdated Show resolved Hide resolved
.husky/pre-commit Show resolved Hide resolved
@rc10house rc10house force-pushed the 446-CI_precommit_hooks_husky branch from f63b88d to 5d0a567 Compare May 14, 2024 15:42
@EandrewJones EandrewJones merged commit 39c0b61 into apache:master May 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants