Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactors gulp using rollup #69

Merged
merged 3 commits into from
Mar 27, 2021
Merged

Conversation

UncleGedd
Copy link
Contributor

@UncleGedd UncleGedd commented Mar 23, 2021

Refactors Gulp, issue # 67

I have done this work using both Webpack and Rollup, and Rollup is by far the easier solution both in terms of setup and extensibility IMO. Also, Rollup is created specifically for the purpose of building flat libraries, whereas Webpack has many bells and whistles that make it quite complex to set up but great for web apps.

  • Refactors build tooling using Rollup (went from a 192-line gulpfile.js to a 61-line rollup.config.js
  • Modifies npm pretest hook
  • Adds mocha and eslint (non-Gulp versions)
  • Removes Gulp and other dev dependencies (composer, del, uglify-es)
  • Regenerated package-lock.json
  • Adds babel transpiling during builds (see this comment from PR # 70

@poorejc
Copy link
Contributor

poorejc commented Mar 24, 2021

Merged earlier PRs, but want to test the new build pipeline on updated test branch. Will test and review tomorrow thanks again @UncleGedd

@UncleGedd
Copy link
Contributor Author

Just rebased from master pulling in the cypress journey changes and resolved the resulting conflicts

@asfgit asfgit merged commit 05eea25 into apache:master Mar 27, 2021
@poorejc poorejc self-assigned this Mar 27, 2021
@poorejc poorejc added enhancement maintenance package updates and the like labels Mar 27, 2021
@poorejc poorejc linked an issue Mar 27, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement maintenance package updates and the like
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Gulp Build Pipeline
3 participants