[FLINK-30702] Add Elasticsearch dialect #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzegorz8
changed the title
eskabetxe
reviewed
Aug 6, 2024
There was a problem hiding this comment.
Overall, everything seems to be fine.
However, I suggest changing the module name to "flink-connector-jdbc-elasticsearch."
I still have some doubts about:
- whether this should be part of the Elasticsearch connector: "https://github.com/apache/flink-connector-elasticsearch."
- the use of trial version
The recent refactor makes this feasible, as you only need to import jdbc-core.
@1996fanrui, what do you think?
@RocMarshal, could you take a look as well?
Hi! @1996fanrui @RocMarshal Any thoughts? |
|
Sorry, I'm not familiar with jdbc and elasticserarch connector. |
Comment on lines
+68
to
+73
| <dependency> | ||
| <groupId>org.elasticsearch.plugin</groupId> | ||
| <artifactId>x-pack-sql-jdbc</artifactId> | ||
| <version>${elasticsearch.version}</version> | ||
| <scope>provided</scope> | ||
| </dependency> |
There was a problem hiding this comment.
- According to https://discuss.elastic.co/t/the-documentation-does-not-seem-to-document-the-minimum-jdk-runtime-requirement-for-org-elasticsearch-plugin-x-pack-sql-jdbc/372078/3?u=linghengqian and The documentation does not seem to document the minimum JDK runtime requirement for
org.elasticsearch.plugin:x-pack-sql-jdbcelastic/elasticsearch#119924 , the committer of ElasticSearch pointed out thatorg.elasticsearch.plugin:x-pack-sql-jdbcis mainly used inside ElasticSearch. It is not suitable for scenarios including Flink.
I don't understand. The plugin runs inside Elasticsearch so it uses the JVM provided by Elasticsearch.
It's not meant to be reused anywhere else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds Elasticsearch dialect.
Important facts:
x-pack-sql-jdbcdependency is on Elastic license which is not compatible with Apache license. Therefore:x-pack-sql-jdbchasprovidedscope.This PR replaces #67. Due to recent refactoring it was easier to create a new PR.