Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-21569] Upgrade flink-shaded-jackson version to 2.12.1-13.0 #16642

Merged
merged 2 commits into from
Aug 3, 2021
Merged

[FLINK-21569] Upgrade flink-shaded-jackson version to 2.12.1-13.0 #16642

merged 2 commits into from
Aug 3, 2021

Conversation

tsreaper
Copy link
Contributor

@tsreaper tsreaper commented Jul 30, 2021

What is the purpose of the change

This PR aims to fix FLINK-21569, where reading specific csv files will cause the job to hang forever. This is actually caused by a bug in Jackson (FasterXML/jackson-dataformats-text#191), so we're upgrading flink-shaded-jackson version in this fix.

Brief change log

  • Upgrade flink-shaded-jackson version to 2.12.1-13.0

Verifying this change

This change added tests and can be verified by running the added tests. It can also be tested by hand with the following steps.

  1. Download this csv file.
  2. Add the following test to a model which relies both on flink-csv and flink-table-planner-blink. For example the flink-sql-client module. Don't forget to change the file path in the DDL.
public class MyTest {

    @Test
    public void myTest() throws Exception {
        EnvironmentSettings settings = EnvironmentSettings.newInstance().inStreamingMode().build();
        TableEnvironment tEnv = TableEnvironmentImpl.create(settings);
        tEnv
                .getConfig()
                .getConfiguration()
                .setInteger(ExecutionConfigOptions.TABLE_EXEC_RESOURCE_DEFAULT_PARALLELISM, 2);
        tEnv
                .executeSql(
                        "CREATE TABLE `airports` (\n"
                                + "  `IATA_CODE` CHAR(3),\n"
                                + "  `AIRPORT` STRING,\n"
                                + "  `CITY` STRING,\n"
                                + "  `STATE` CHAR(2),\n"
                                + "  `COUNTRY` CHAR(3),\n"
                                + "  `LATITUDE` DOUBLE NULL,\n"
                                + "  `LONGITUDE` DOUBLE NULL,\n"
                                + "  PRIMARY KEY (`IATA_CODE`) NOT ENFORCED\n"
                                + ") WITH (\n"
                                + "  'connector' = 'filesystem',\n"
                                + "  'path' = 'file:///tmp/airports.csv',\n"
                                + "  'format' = 'csv',\n"
                                + "  'csv.allow-comments' = 'true',\n"
                                + "  'csv.ignore-parse-errors' = 'true',\n"
                                + "  'csv.null-literal' = ''\n"
                                + ")")
                .await();
        tEnv.executeSql("SELECT * FROM airports").print();
    }
}
  1. Run the test. Before this fix the test will hang forever. After this fix the test will end successfully.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): YES
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 30, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 6058577 (Sat Aug 28 13:06:52 UTC 2021)

Warnings:

  • 1 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 30, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you create a case for "Flink SQL with CSV file input job hangs"?

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can consider creating some special data to reproduce this problem.

@tsreaper tsreaper requested a review from JingsongLi July 31, 2021 00:46
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! +1

@JingsongLi JingsongLi merged commit e621c70 into apache:release-1.12 Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants