-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-21569] Upgrade flink-shaded-jackson version to 2.12.1-13.0 #16642
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 6058577 (Sat Aug 28 13:06:52 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you create a case for "Flink SQL with CSV file input job hangs"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can consider creating some special data to reproduce this problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! +1
What is the purpose of the change
This PR aims to fix FLINK-21569, where reading specific csv files will cause the job to hang forever. This is actually caused by a bug in Jackson (FasterXML/jackson-dataformats-text#191), so we're upgrading flink-shaded-jackson version in this fix.
Brief change log
Verifying this change
This change added tests and can be verified by running the added tests. It can also be tested by hand with the following steps.
flink-csv
andflink-table-planner-blink
. For example theflink-sql-client
module. Don't forget to change the file path in the DDL.Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation