Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): unify type system between python and xlang serialization in pyfury #2034

Merged

Conversation

chaokunyang
Copy link
Collaborator

@chaokunyang chaokunyang commented Jan 31, 2025

What does this PR do?

This pr unifies type system between python and xlang serialization in pyfury, so that we can remove duplicate code in pyfury, and lay the foundation for following features:

  • implement protocol such as chunk based map serialization for pythobn and xlang serialization
  • use python exsiting fastpath optimization in xlang serialization
  • extend DataClassSerializer to support codegen based serialization for xlang

Related issues

#1690

Does this PR introduce any user-facing change?

  • Does this PR introduce any public API change?
  • Does this PR introduce any binary protocol compatibility change?

Benchmark

@chaokunyang
Copy link
Collaborator Author

cc @penguin-wwy

Copy link
Contributor

@pandalee99 pandalee99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pandalee99 pandalee99 merged commit b4f5a2a into apache:main Jan 31, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants