fix: use compose v2 syntax

[kahnwong]

In docker compose v2, the command docker-compose has been updated to docker compose. Ref: https://docs.docker.com/compose/releases/migrate/.

In this pr, in addition to existing check for availability of docker-compose, it also sees if docker compose exists.

Previously, if your system has compose v2, the launch script would fail. With this pr, systems using compose v2 will not result in an exit code.

[kahnwong]

forgot to update the actual compose command, will create a commit for it

[xunliu]

hi @kahnwong Thank you for your contribution to this PR.
@unknowntpo Please help review this PR If you have time, Thanks.

[ryankert01]

Hi! Thank you for the patch, some nits left.

[ryankert01]

I think we should prioritize docker compose since it's newer.

[unknowntpo]

I agree with @ryankert01 , since recent version of docker shipped with docker compose, it's better to use recent version of docker to eliminate potential bugs.

[kahnwong]

Thank you both for the comments.

I agree that it should be docker compose syntax, in that case I will do following:

1. rename this pr to fix: use compose v2 syntax
2. Checkout code from main/master and replace docker-compose with docker compose

Is there anything I'm missing?

[kahnwong]

I propose this version of launch-playground.sh

# redacted shebang and license

playground_dir="$(dirname "${BASH_SOURCE-$0}")"
playground_dir="$(cd "${playground_dir}">/dev/null; pwd)"

# check for `docker compose`
isExist=`docker --help | grep compose`
if [ $? -eq 0 ]; then
    true # Placeholder, do nothing
else
  echo "ERROR: No docker service environment found, please install compose plugin first."
  exit
fi

components=""
case "${1}" in
  *)
    components=$@
esac

cd ${playground_dir}
docker compose up ${components}

# Clean Docker containers when you quit this script
docker compose down

In which if everyone approves, I will then:

1. Create a new commit with this version of launch-playground.sh
2. Rename this pr to: fix: use compose v2 syntax

Please let me know if I missed anything.

[ryankert01]

Hi @kahnwong, it looks good! Could you commit it to the PR branch?

[ryankert01]

lgtm

[ryankert01]

cc @unknowntpo @xunliu for final review

[unknowntpo]

LGTM

[jhchee]

Hihi @kahnwong Are you still working on this? This will be QoL improvement for users that use docker compose v2.

[kahnwong]

Hihi @kahnwong Are you still working on this? This will be QoL improvement for users that use docker compose v2.

I'm still working on this. I noticed from the latest commit, the file I've worked on has been renamed to another file.

Will create a commit for compose syntax upgrade.

[kahnwong]

@jhchee rebased the pr and apply compose syntax migration. Please kindly review this PR.

[jhchee]

Thanks @kahnwong, I can attest your change is working! However, I'm not a contributor of this project, so will likely need other to approve this PR.
Gentle ping @unknowntpo if you have the time to review this 🙏

[unknowntpo]

LGTM, ping @xunliu