Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Stoppable Check for Non-Topology-Aware Clusters #2961

Conversation

MarkGaox
Copy link
Contributor

@MarkGaox MarkGaox commented Nov 12, 2024

Issues

Description

  • Here are some details about my PR, including screenshots of any UI changes:
  • Add a new selection base: NON_TOPO_BASED. In this scenario, the order of the zone will not be respected and all instances will be performed stoppable check at once. Additionally, this change supports the stoppable check for non-topo aware clusters.

Tests

  • The following tests are written for this issue:
    mvn test -Dtest=TestInstancesAccessor,TestMaintenanceManagementService,TestInstanceValidationUtilInRest,TestPerInstanceAccessor,TestCustomRestClient,TestClusterService -pl helix-rest && mvn test -Dtest=TestInstanceValidationUtil -pl helix-core

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@MarkGaox MarkGaox marked this pull request as ready for review November 12, 2024 18:25
@MarkGaox MarkGaox force-pushed the markgaox/support-non-topology-aware-stoppable-check branch from 855e7d6 to 13950a6 Compare November 26, 2024 00:00
Copy link
Contributor

@xyuanlu xyuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some minor style issue.

Copy link
Contributor

@xyuanlu xyuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! some nit.

@MarkGaox
Copy link
Contributor Author

PR approved by @xyuanlu. TFTR. Final commit message: "Support Stoppable Check for Non-Topology-Aware Clusters"

@xyuanlu xyuanlu merged commit 33a28e7 into apache:master Dec 11, 2024
2 checks passed
zpinto pushed a commit to zpinto/helix that referenced this pull request Jan 22, 2025
Support Stoppable Check for Non-Topology-Aware Clusters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants