-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Stoppable Check for Non-Topology-Aware Clusters #2961
Support Stoppable Check for Non-Topology-Aware Clusters #2961
Conversation
...rc/main/java/org/apache/helix/rest/clusterMaintenanceService/StoppableInstancesSelector.java
Outdated
Show resolved
Hide resolved
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/InstancesAccessor.java
Outdated
Show resolved
Hide resolved
helix-rest/src/test/java/org/apache/helix/rest/server/AbstractTestClass.java
Show resolved
Hide resolved
...rc/main/java/org/apache/helix/rest/clusterMaintenanceService/StoppableInstancesSelector.java
Outdated
Show resolved
Hide resolved
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/InstancesAccessor.java
Show resolved
Hide resolved
855e7d6
to
13950a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Some minor style issue.
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/InstancesAccessor.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/helix/rest/clusterMaintenanceService/StoppableInstancesSelector.java
Show resolved
Hide resolved
...rc/main/java/org/apache/helix/rest/clusterMaintenanceService/StoppableInstancesSelector.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! some nit.
...rc/main/java/org/apache/helix/rest/clusterMaintenanceService/StoppableInstancesSelector.java
Outdated
Show resolved
Hide resolved
PR approved by @xyuanlu. TFTR. Final commit message: "Support Stoppable Check for Non-Topology-Aware Clusters" |
Support Stoppable Check for Non-Topology-Aware Clusters
Issues
Request - Make batch instances stoppable request work for clusters without topology setup #2893
Description
Tests
mvn test -Dtest=TestInstancesAccessor,TestMaintenanceManagementService,TestInstanceValidationUtilInRest,TestPerInstanceAccessor,TestCustomRestClient,TestClusterService -pl helix-rest && mvn test -Dtest=TestInstanceValidationUtil -pl helix-core
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)