Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP: do not review] HIVE-28712: Fix error wrt maxParts in partition logs #5635

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP: do not review] HIVE-28712: Fix error wrt maxParts in partition logs #5635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -810,10 +810,10 @@ private void startPartitionFunction(String function, String catName, String db,
+ maxParts);
}

private void startPartitionFunction(String function, String catName, String db, String tbl, int maxParts,
private void startPartitionFunction(String function, String catName, String db, String tbl, int partitionLimit,
String expression, String defaultPartitionName) {
startFunction(function, " : tbl=" + TableName.getQualified(catName, db, tbl) + ": Expression=" + expression
+ ": Default partition name=" + defaultPartitionName + ": Max partitions=" + maxParts);
+ ": Default partition name=" + defaultPartitionName + ": Max partitions=" + partitionLimit);
}

private String getGroupsCountAndUsername(final String user_name, final List<String> group_names) {
Expand Down Expand Up @@ -7601,8 +7601,8 @@ public PartitionsByExprResult get_partitions_by_expr(
String catName = req.isSetCatName() ? req.getCatName() : getDefaultCatalog(conf);
String expr = req.isSetExpr() ? Arrays.toString((req.getExpr())) : "";
String defaultPartitionName = req.isSetDefaultPartitionName() ? req.getDefaultPartitionName() : "";
int maxParts = req.getMaxParts();
startPartitionFunction("get_partitions_by_expr", catName, dbName, tblName, maxParts, expr, defaultPartitionName);
int partitionLimit = MetastoreConf.getIntVar(conf, MetastoreConf.ConfVars.LIMIT_PARTITION_REQUEST);
startPartitionFunction("get_partitions_by_expr", catName, dbName, tblName, partitionLimit, expr, defaultPartitionName);
fireReadTablePreEvent(catName, dbName, tblName);
PartitionsByExprResult ret = null;
Exception ex = null;
Expand Down
Loading