Implement username* validation and decoding in DigestScheme #511
Conversation
|
|
||
| // Extract username and username* | ||
| String username = credentials.getUserName(); | ||
| final String usernameStar = paramMap.get("username*"); |
There was a problem hiding this comment.
@arturobernalg This looks wrong. The server is not supposed to be sending us username* in the auth challenge, or at any rate, we should not be using it. We should only be using the username provided by CredentialsProvider.
There was a problem hiding this comment.
HI @ok2c
you're right. Please do another pass.
TY
arturobernalg
force-pushed
the
username_validaions_2
branch
4 times, most recently
from
fa714a1 to
3fcc9f6
Compare
| if (u != -1 && l != -1) { | ||
| bb.put((byte) ((u << 4) + l)); | ||
| } else { | ||
| throw new IllegalArgumentException("Invalid percent encoding in " + s); |
There was a problem hiding this comment.
@arturobernalg Can we throw a better exception here, like CodingException of some sort, which could be caught at a higher level and translated in a proper protocol exception?
| * should not be used as part of the public API. | ||
| */ | ||
| @Internal | ||
| class RFC5987Codec { |
There was a problem hiding this comment.
@arturobernalg There is a similar implementation in the HttpRFC7578Multipart class. Could you please get rid of it in this or a follow-up change-set?
Introduces validation and decoding logic for the 'username*' field in the DigestScheme class. The changes ensure compliance with RFC 7616 and RFC 5987 by handling cases where the 'username' contains characters not allowed in an ABNF quoted-string.
arturobernalg
force-pushed
the
username_validaions_2
branch
from
4cc80db to
9dab859
Compare
|
@ok2c please take another look. |
Introduces validation and decoding logic for the 'username*' field in the DigestScheme class. The changes ensure compliance with RFC 7616 and RFC 5987 by handling cases where the 'username' contains characters not allowed in an ABNF quoted-string.
Introduces validation and decoding logic for the 'username*' field in the DigestScheme class. The changes ensure compliance with RFC 7616 and RFC 5987 by handling cases where the 'username' contains characters not allowed in an ABNF quoted-string.