Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: HTTP response content being truncated to a maximum length of 256 bytes #519

Closed
wants to merge 2 commits into from

Conversation

Demonese
Copy link

@Demonese Demonese commented Dec 9, 2023

see commit: 0df9e63

Demonese referenced this pull request Dec 9, 2023
This commit enhances the `ContentResponseHandler` class to be more fault-tolerant by handling responses with null or empty bodies without throwing exceptions. If the response was successful (a 2xx status code), the `Content` object is returned. If no response body exists, `Content.NO_CONTENT` is returned.

The implementation extends `ContentResponseHandler` and overrides its methods to handle the response entity and transform it into the actual response object. This is designed to be efficient and use minimal memory.
@garydgregory
Copy link
Member

Hello @Demonese
Would you please write a test that demonstrates the problem?

@Demonese
Copy link
Author

Demonese commented Dec 9, 2023

Would you please write a test that demonstrates the problem?

Of course, you can compare whether the test case passes before/after apply fix.

@ok2c
Copy link
Member

ok2c commented Dec 11, 2023

Superseded by 7d853d5

@ok2c ok2c closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants