Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): Typo in ClientConfiguration example #604

Merged
merged 1 commit into from
Dec 2, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -126,8 +126,8 @@ public Header parseHeader(final CharArrayBuffer buffer) {
};
final HttpMessageWriterFactory<ClassicHttpRequest> requestWriterFactory = new DefaultHttpRequestWriterFactory();

// Create connection configuration
final CharCodingConfig connectionConfig = CharCodingConfig.custom()
// Create char coding configuration
final CharCodingConfig charCodingConfig = CharCodingConfig.custom()
.setMalformedInputAction(CodingErrorAction.IGNORE)
.setUnmappableInputAction(CodingErrorAction.IGNORE)
.setCharset(StandardCharsets.UTF_8)
@@ -138,7 +138,7 @@ public Header parseHeader(final CharArrayBuffer buffer) {
// configuration parameters HTTP connection factory can define message
// parser / writer routines to be employed by individual connections.
final HttpConnectionFactory<ManagedHttpClientConnection> connFactory = new ManagedHttpClientConnectionFactory(
h1Config, connectionConfig, requestWriterFactory, responseParserFactory);
h1Config, charCodingConfig, requestWriterFactory, responseParserFactory);

// Client HTTP connection objects when fully initialized can be bound to
// an arbitrary network socket. The process of network socket initialization,