[HUDI-8789] Dropping hbase deps from presto/trino bundle (#12532)

apache · Dec 21, 2024 · 217956c · 217956c
1 parent 10cc461
commit 217956c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 44 deletions.
diff --git a/packaging/hudi-presto-bundle/pom.xml b/packaging/hudi-presto-bundle/pom.xml
@@ -81,9 +81,7 @@
                   <include>org.codehaus.jackson:*</include>
                   <include>org.apache.commons:commons-lang3</include>
                   <include>com.yammer.metrics:metrics-core</include>
-                  <include>com.google.guava:guava</include>
                   <include>commons-io:commons-io</include>
-                  <include>commons-lang:commons-lang</include>
                   <include>com.google.protobuf:protobuf-java</include>
                   <include>org.openjdk.jol:jol-core</include>
                 </includes>
@@ -211,26 +209,8 @@
       <scope>compile</scope>
     </dependency>
 
-    <!--Guava needs to be shaded because HBase 1.2.3 depends on an earlier guava version i.e 12.0.1 and hits runtime
-    issues with the guava version present in Presto runtime-->
-    <dependency>
-      <groupId>com.google.guava</groupId>
-      <artifactId>guava</artifactId>
-      <version>12.0.1</version>
-      <scope>${presto.bundle.bootstrap.scope}</scope>
-    </dependency>
-
-    <!--commons-lang needs to be shaded because HBase 1.2.3 needs it at runtime, but Presto runtime does not have this
-    dependency-->
-    <dependency>
-      <groupId>commons-lang</groupId>
-      <artifactId>commons-lang</artifactId>
-      <version>2.6</version>
-      <scope>${presto.bundle.bootstrap.scope}</scope>
-    </dependency>
-
-    <!--protobuf needs to be shaded because HBase 1.2.3 needs it at runtime, but Presto runtime does not have this
-    dependency-->
+    <!--protobuf needs to be shaded because HBase 1.2.3 and our native reader needs it at runtime,
+    but Presto runtime does not have this dependency-->
     <dependency>
       <groupId>com.google.protobuf</groupId>
       <artifactId>protobuf-java</artifactId>

diff --git a/packaging/hudi-trino-bundle/pom.xml b/packaging/hudi-trino-bundle/pom.xml
@@ -83,8 +83,6 @@
                   <include>com.github.ben-manes.caffeine:caffeine</include>
                   <include>org.codehaus.jackson:*</include>
                   <include>com.yammer.metrics:metrics-core</include>
-                  <include>com.google.guava:guava</include>
-                  <include>commons-lang:commons-lang</include>
                   <include>commons-io:commons-io</include>
                   <include>com.google.protobuf:protobuf-java</include>
                   <include>org.openjdk.jol:jol-core</include>
@@ -217,26 +215,8 @@
       <scope>compile</scope>
     </dependency>
 
-    <!--Guava needs to be shaded because HBase 1.2.3 depends on an earlier guava version i.e 12.0.1 and hits runtime
-    issues with the guava version present in Trino runtime-->
-    <dependency>
-      <groupId>com.google.guava</groupId>
-      <artifactId>guava</artifactId>
-      <version>12.0.1</version>
-      <scope>${trino.bundle.bootstrap.scope}</scope>
-    </dependency>
-
-    <!--commons-lang needs to be shaded because HBase 1.2.3 needs it at runtime, but Trino runtime does not have this
-    dependency-->
-    <dependency>
-      <groupId>commons-lang</groupId>
-      <artifactId>commons-lang</artifactId>
-      <version>2.6</version>
-      <scope>${trino.bundle.bootstrap.scope}</scope>
-    </dependency>
-
-    <!--protobuf needs to be shaded because HBase 1.2.3 needs it at runtime, but Trino runtime does not have this
-    dependency-->
+    <!--protobuf needs to be shaded because HBase 1.2.3 + native HFile reader needs it at runtime,
+    but Trino runtime does not have this dependency-->
     <dependency>
       <groupId>com.google.protobuf</groupId>
       <artifactId>protobuf-java</artifactId>