Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Populate the log record with file name instead of file id #12494

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

TheR1sing3un
Copy link
Member

The _hoodie_file_name field in log record is currently populated with the file id, which does not match the intended meaning of the field, so the actual file name is used.

Change Logs

  1. populate the log record with file name instead of file id
    Describe context and summary for this change. Highlight if any code was copied.

Impact

Describe any public API or user-facing feature change or any performance impact.
none

Risk level (write none, low medium or high below)

none
If medium or high, explain what verification was done to mitigate the risks.

Documentation Update

none
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

1. populate the log record with file name instead of file id

Signed-off-by: TheR1sing3un <chaoyang@apache.org>
@github-actions github-actions bot added the size:XS PR with lines of changes in <= 10 label Dec 16, 2024
1. get file id from `_hoodie_file_name` field in log record

Signed-off-by: TheR1sing3un <chaoyang@apache.org>
@github-actions github-actions bot added size:S PR with lines of changes in (10, 100] and removed size:XS PR with lines of changes in <= 10 labels Dec 16, 2024
1. fix wrong verify logic in TestRecordLevelIndex

Signed-off-by: TheR1sing3un <chaoyang@apache.org>
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@danny0405
Copy link
Contributor

@vinothchandar Is this by-design or just a mistake?

@TheR1sing3un
Copy link
Member Author

@vinothchandar Is this by-design or just a mistake?

I think we fill the field with file_name and we can parse the file_id from the file_name, but if we only fill the field with file_id, we will never know the real file_name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S PR with lines of changes in (10, 100]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants