Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Avoid unnecessary storage interactions for heartbeat #12521

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheR1sing3un
Copy link
Member

Check if the current heartbeat has expired before update it.

Change Logs

  1. avoid unnecessary storage interactions for heartbeat
    Describe context and summary for this change. Highlight if any code was copied.

Impact

Describe any public API or user-facing feature change or any performance impact.
none

Risk level (write none, low medium or high below)

none
If medium or high, explain what verification was done to mitigate the risks.

Documentation Update

none
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

1. avoid unnecessary storage interactions for heartbeat

Signed-off-by: TheR1sing3un <[email protected]>
@github-actions github-actions bot added the size:S PR with lines of changes in (10, 100] label Dec 19, 2024
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@danny0405
Copy link
Contributor

we should always trigger the heartbeat no matter whether it is expired or not.

@TheR1sing3un
Copy link
Member Author

we should always trigger the heartbeat no matter whether it is expired or not.

What is the purpose of this?

@TheR1sing3un
Copy link
Member Author

we should always trigger the heartbeat no matter whether it is expired or not.

Is it because it prevents other write-operation from cleaning the task while executing clean even though the write-operation is still running?

@danny0405
Copy link
Contributor

danny0405 commented Dec 23, 2024

we should always trigger the heartbeat no matter whether it is expired or not.

Is it because it prevents other write-operation from cleaning the task while executing clean even though the write-operation is still running?

The writer should not be aware of the reader. We should always report the heartbeat if the writer works correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S PR with lines of changes in (10, 100]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants