Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HUDI-8786] Running intellij code cleanup #12524

Merged
merged 1 commit into from
Feb 21, 2025
Merged

[HUDI-8786] Running intellij code cleanup #12524

merged 1 commit into from
Feb 21, 2025

Conversation

vinothchandar
Copy link
Member

Change Logs

  • final modified added as needed
  • eliminate unnecessary .toString()
  • Move out of StringBuilder for toString, since the compiler will do it anyway
  • Bunch of simplifications

All the changes are auto generated.

Impact

None

Risk level (write none, low medium or high below)

low

Documentation Update

none

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@vinothchandar vinothchandar changed the title [DRAFT] Running intellij code cleanup [HUDI-8786] Running intellij code cleanup Dec 19, 2024
@github-actions github-actions bot added the size:XL PR with lines of changes > 1000 label Dec 19, 2024
yihua
yihua reviewed Dec 30, 2024
View reviewed changes
Copy link
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I'll still test the changes in EMR cluster to make sure there is no issue around serialization in a Spark job.

vinothchandar
vinothchandar commented Feb 20, 2025
View reviewed changes
Copy link
Member Author

@vinothchandar vinothchandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased.. Will address the one fix. Run SQL Quickstart on a local Spark cluster and land if the final/transient concern is resolved.

@vinothchandar
[HUDI-8786] IntelliJ automatic code cleanup tool
7f32300 
 - IDEA code cleanup changes
 - On top, fixed to make checkstyle happy
 - keeping `final transient` changes back as `transient`
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

yihua
yihua approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We synced offline and it looks to me that the transient/final concern is no longer relevant (reference is either relevant or outdated). As long as tests pass we should go ahead landing this.

@vinothchandar
Copy link
Member Author

CI timed out, retried. Its green here now.
https://dev.azure.com/apachehudi/hudi-oss-ci/_build/results?buildId=3770

@vinothchandar vinothchandar merged commit b62b2cc into apache:master Feb 21, 2025
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihua yihua yihua approved these changes

@linliu-code linliu-code linliu-code approved these changes

Assignees
No one assigned
Labels
size:XL PR with lines of changes > 1000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vinothchandar @hudi-bot @yihua @linliu-code