REST: Avoid deprecated execute without HttpClientResponseHandler #11870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborkaszab
reviewed
Jan 9, 2025
| try { | ||
| return httpClient.execute( | ||
| request, | ||
| response -> { |
There was a problem hiding this comment.
The change in general makes sense to me. Just a minor question: Do you think it would make sense to move this logic into a ResponseHandler member of this class? Seems a bit long to me to include it here as a lambda, and we'd save some indentation too if it was a separate member.
| response.getCode(), | ||
| responseType.getSimpleName()); | ||
| } | ||
| try { |
There was a problem hiding this comment.
The other execute() function we called throws IOException while this one can additionally throw ClientProtocolException. Not sure if we have to catch it here or not, though, just wanted to raise attention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hc.apache.org/httpcomponents-client-5.4.x/current/apidocs/org/apache/hc/client5/http/classic/HttpClient.html#execute-org.apache.hc.core5.http.ClassicHttpRequest-