Spark 3.5: Avoid deprecated method #11874
Open
+98
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
commented
Dec 25, 2024
| @@ -251,7 +251,8 @@ private String getCompressionType(InputFile inputFile) throws Exception { | |||
| return orcReader.getCompressionKind().name(); | |||
| case PARQUET: | |||
| ParquetMetadata footer = | |||
| ParquetFileReader.readFooter(CONF, new Path(inputFile.location()), NO_FILTER); | |||
There was a problem hiding this comment.
readFooter method is deprecated: https://javadoc.io/doc/org.apache.parquet/parquet-hadoop/latest/index.html
ebyhr
commented
Dec 25, 2024
| @@ -107,8 +107,8 @@ public void testAlterTable() throws NoSuchTableException { | |||
|
|
|||
| assertThat(table).as("Should return updated table").isNotNull(); | |||
|
|
|||
| StructField expectedField = DataTypes.createStructField(fieldName, DataTypes.StringType, true); | |||
| assertThat(table.schema().fields()[2]) | |||
There was a problem hiding this comment.
ebyhr
commented
Dec 25, 2024
|
|
||
| } finally { | ||
| visitor.fieldNames.pop(); | ||
| if (annotation.equals(LogicalTypeAnnotation.listType())) { |
There was a problem hiding this comment.
I would recommend reviewing this changer with "Hide whitespace" option.
I changed switch to if because LogicalTypeAnnotation isn't enum.
ebyhr
commented
Dec 25, 2024
| @@ -59,106 +59,101 @@ public static <T> T visit(DataType sType, Type type, ParquetWithSparkSchemaVisit | |||
| } else { | |||
| // if not a primitive, the typeId must be a group | |||
| GroupType group = type.asGroupType(); | |||
| OriginalType annotation = group.getOriginalType(); | |||
There was a problem hiding this comment.
OriginalType enum is deprecated: https://www.javadoc.io/doc/org.apache.parquet/parquet-column/latest/org/apache/parquet/schema/OriginalType.html
|
CI hit #11651 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.