Parquet: Internal writer and reader #11904
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajantha-bhat
commented
Jan 3, 2025
| } | ||
|
|
||
| private static class ParquetStructReader extends StructReader<StructLike, StructLike> { | ||
| private final GenericRecord template; |
There was a problem hiding this comment.
Should I introduce a new class like GenericStruct that implements StructLike, I thought of using StructProjection but it is read only. Hence, need one simple class to create a StructLike objects.
ajantha-bhat
commented
Jan 3, 2025
| required(113, "dec_38_10", Types.DecimalType.of(38, 10))); | ||
|
|
||
| // Consuming the data as per Type.java | ||
| GenericRecord record = GenericRecord.create(schema); |
There was a problem hiding this comment.
Should I introduce a new class like GenericStruct that implements StructLike, I thought of using StructProjection but it is read only. Hence, need one simple class to create a StructLike objects.
Line 95, wrapping this with StructProjection just to get pure StructLike
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitted into 3 commits,
a) Refactor BaseParquetWriter to only keep common functionality required for internal and generic writer.
b) Refactor BaseParquetReaders to only keep common functionality required for internal and generic reader.
c) Add internal writer and reader that consumes and produces the Iceberg in-memory data model.