Auth Manager API part 6: API enablement #12197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbonofre
approved these changes
Feb 9, 2025
snazy
approved these changes
Feb 12, 2025
| * href="https://docs.aws.amazon.com/general/latest/gr/signing-aws-api-requests.html">Signing AWS | ||
| * API requests</a> for details about the protocol. | ||
| */ | ||
| public class RESTSigV4Signer implements HttpRequestInterceptor { |
There was a problem hiding this comment.
Should follow a minor version deprecation?
https://iceberg.apache.org/contribute/?h=contri#minor-version-deprecations-discretionary
There was a problem hiding this comment.
Hi @ajantha-bhat I think the deprecation cycle does not apply here because this component is not meant to be instantiated by users directly. It was only instantiated by reflection when SigV4 was enabled:
iceberg/core/src/main/java/org/apache/iceberg/rest/HTTPClient.java
Lines 558 to 560 in 0bc6dfa
But I'm happy to keep this class around if others think that's better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6th and last PR for the Auth Manager API. Previous ones:
Once this PR is merged, the AuthManager API becomes effective.
Summary of changes:
OAuth2Manager, mostly to properly handle empty auth sessions, as decided in Auth Manager API part 4: RESTClient, HTTPClient #11992;HttpInterceptorcode inHTTPClientand related tests;RESTSessionCatalog;VendedCredentialsProviderandOAuth2RefreshCredentialsHandlerOAuth2RefreshCredentialsHandlernow caches itsHTTPClientandAuthSession, instead of creating a new client and session for every refresh – pretty much likeVendedCredentialsProvideralready does.