Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-24153: Sql. Dml. It is not possible to insert a varchar string that is longer than 65536 characters #5119

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lowka
Copy link
Contributor

@lowka lowka commented Jan 24, 2025

https://issues.apache.org/jira/browse/IGNITE-24153


Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

@lowka lowka force-pushed the ignite-24153 branch 7 times, most recently from a836d5f to 9d8981c Compare January 28, 2025 07:51
@lowka lowka marked this pull request as ready for review January 28, 2025 08:42
/**
* Max length for VARCHAR and VARBINARY types.
*/
public static final int MAX_VARLEN_LENGTH = Integer.MAX_VALUE;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have another JIRA to increase limits: https://issues.apache.org/jira/browse/IGNITE-24154. In this JIRA we need to add validation for DDL statements

@lowka lowka force-pushed the ignite-24153 branch 6 times, most recently from b1e886f to 0aa1706 Compare January 30, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants