Skip to content

Commit

Permalink
fix test
Browse files Browse the repository at this point in the history
  • Loading branch information
lyy-pineapple committed Jul 24, 2024
1 parent 35453da commit 058de7e
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,12 @@ bool SubstraitToVeloxPlanValidator::validate(const ::substrait::GenerateRel& gen
LOG_VALIDATION_MSG("Input validation fails in GenerateRel.");
return false;
}
expressions.emplace_back(exprConverter_->toVeloxExpr(generateRel.generator(), rowType));
auto generator = generateRel.generator().scalar_function();
for (const auto& argument : generator.arguments()) {
if (argument.has_value()) {
expressions.emplace_back(exprConverter_->toVeloxExpr(argument.value(), rowType));
}
}
// Try to compile the expressions. If there is any unregistred funciton or
// mismatched type, exception will be thrown.
exec::ExprSet exprSet(std::move(expressions), execCtx_);
Expand Down

0 comments on commit 058de7e

Please sign in to comment.