Skip to content

Commit

Permalink
disable sort shuffle
Browse files Browse the repository at this point in the history
  • Loading branch information
liuneng1994 committed Jun 7, 2024
1 parent 17697fa commit 12939b1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cpp-ch/local-engine/Shuffle/CachedShuffleWriter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,9 @@ void CachedShuffleWriter::lazyInitPartitionWriter(Block & input_sample)

auto avg_row_size = input_sample.allocatedBytes() / input_sample.rows();
auto overhead_memory = std::max(avg_row_size, input_sample.columns() * 16) * options.split_size * options.partition_num;
auto use_sort_shuffle = overhead_memory > options.spill_threshold * 0.5 || options.partition_num >= 300;
// auto use_sort_shuffle = overhead_memory > options.spill_threshold * 0.5 || options.partition_num >= 300;
auto use_external_sort_shuffle = options.force_external_sort;
auto use_memory_sort_shuffle = options.force_mermory_sort || use_sort_shuffle;
auto use_memory_sort_shuffle = options.force_mermory_sort;
sort_shuffle = use_memory_sort_shuffle || use_external_sort_shuffle;
if (celeborn_client)
{
Expand Down

0 comments on commit 12939b1

Please sign in to comment.