Fix to_date function short circuit execute

apache · Jun 11, 2024 · 1f4294e · 1f4294e
1 parent ec3e92e
commit 1f4294e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/cpp-ch/local-engine/Functions/FunctionGetDateData.h b/cpp-ch/local-engine/Functions/FunctionGetDateData.h
@@ -46,17 +46,14 @@ class FunctionGetDateData : public DB::IFunction
     FunctionGetDateData() = default;
     ~FunctionGetDateData() override = default;
 
-    DB::ColumnPtr executeImpl(const DB::ColumnsWithTypeAndName & arguments, const DB::DataTypePtr & result_type, size_t) const override
+    DB::ColumnPtr executeImpl(const DB::ColumnsWithTypeAndName & arguments, const DB::DataTypePtr &, size_t) const override
     {
         if (arguments.size() != 1)
             throw DB::Exception(DB::ErrorCodes::NUMBER_OF_ARGUMENTS_DOESNT_MATCH, "Function {}'s arguments number must be 1.", getName());
 
         const DB::ColumnWithTypeAndName arg1 = arguments[0];
         const auto * src_col = checkAndGetColumn<DB::ColumnString>(arg1.column.get());
         size_t size = src_col->size();
-
-        if (!result_type->isNullable())
-            throw DB::Exception(DB::ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT, "Function {}'s return type must be nullable", getName());
 
         using ColVecTo = ColumnVector<T>;
         typename ColVecTo::MutablePtr result_column = ColVecTo::create(size, 0);

diff --git a/cpp-ch/local-engine/Functions/SparkFunctionToDateTime.h b/cpp-ch/local-engine/Functions/SparkFunctionToDateTime.h
@@ -145,9 +145,6 @@ class SparkFunctionConvertToDateTime : public IFunction
          if (arguments.size() != 1 && arguments.size() != 2)
             throw DB::Exception(DB::ErrorCodes::NUMBER_OF_ARGUMENTS_DOESNT_MATCH, "Function {}'s arguments number must be 1 or 2.", name);
 
-        if (!result_type->isNullable())
-            throw DB::Exception(DB::ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT, "Function {}'s return type must be nullable", name);
-
         if (!isDateTime64(removeNullable(result_type)))
             throw DB::Exception(DB::ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT, "Function {}'s return type must be datetime.", name);