Skip to content

Commit

Permalink
[GLUTEN-7495][BUILD] Fix macOS does not support version-script (#7497)
Browse files Browse the repository at this point in the history
  • Loading branch information
zml1206 authored Oct 12, 2024
1 parent 493a0ab commit 21ff0fe
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions cpp/core/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,10 @@ add_dependencies(gluten jni_proto)
# Hide symbols of some static dependencies. Otherwise, if such dependencies are
# already statically linked to libvelox.so, a runtime error will be reported:
# xxx is being linked both statically and dynamically.
target_link_options(
gluten PRIVATE -Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/symbols.map)
if(NOT CMAKE_SYSTEM_NAME MATCHES "Darwin")
target_link_options(
gluten PRIVATE -Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/symbols.map)
endif()

if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 9.0)
execute_process(
Expand Down

0 comments on commit 21ff0fe

Please sign in to comment.