Skip to content

Commit

Permalink
tpcds - pass 3.5 ut
Browse files Browse the repository at this point in the history
  • Loading branch information
baibaichen committed Jul 30, 2024
1 parent 428a65f commit 331cb88
Showing 1 changed file with 14 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -57,19 +57,22 @@ abstract class GlutenClickHouseTPCDSAbstractSuite
} else {
Seq("q" + "%d".format(queryNum))
}
val native = queryNum match {
case i if !isAqe && (i == 10 || i == 16 || i == 35 || i == 94) =>
// q10, q35 smj + existence join
// q16 smj + left semi + not condition
// Q94 BroadcastHashJoin, LeftSemi, NOT condition
false
case i if isAqe && (i == 16 || i == 94) =>
false
case _ => true
}
val native = !fallbackSets(isAqe).contains(queryNum)
sqlNums.map((_, native))
})

protected def fallbackSets(isAqe: Boolean): Set[Int] = {
val more = if (isSparkVersionGE("3.5")) Set(44, 67, 70) else Set.empty[Int]

// q16 smj + left semi + not condition
// Q94 BroadcastHashJoin, LeftSemi, NOT condition
if (isAqe) {
Set(16, 94) | more
} else {
// q10, q35 smj + existence join
Set(10, 16, 35, 94) | more
}
}
protected def excludedTpcdsQueries: Set[String] = Set(
"q66" // inconsistent results
)
Expand All @@ -82,7 +85,7 @@ abstract class GlutenClickHouseTPCDSAbstractSuite
runTPCDSQuery(s._1, noFallBack = s._2) { df => }
}
} else {
val tag = if (s._2) "Native" else "Vanilla"
val tag = if (s._2) "Native" else "Fallback"
test(s"TPCDS[$tag] ${s._1.toUpperCase()}") {
runTPCDSQuery(s._1, noFallBack = s._2) { df => }
}
Expand Down

0 comments on commit 331cb88

Please sign in to comment.