Skip to content

Commit

Permalink
[GLUTEN-3711][VL] Fix printConf to Support Velox Config #3710
Browse files Browse the repository at this point in the history
Co-authored-by: Ted Jenks <[email protected]>
  • Loading branch information
ted-jenks and Ted Jenks authored Nov 15, 2023
1 parent 857872e commit 36c9208
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions cpp/velox/compute/VeloxBackend.cc
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,10 @@ const std::string kVeloxShuffleReaderPrintFlag = "spark.gluten.velox.shuffleRead

namespace gluten {

void VeloxBackend::printConf(const std::unordered_map<std::string, std::string>& conf) {
void VeloxBackend::printConf(const facebook::velox::Config& conf) {
std::ostringstream oss;
oss << "STARTUP: VeloxBackend conf = {\n";
for (auto& [k, v] : conf) {
for (auto& [k, v] : conf.values()) {
oss << " {" << k << ", " << v << "}\n";
}
oss << "}\n";
Expand Down
2 changes: 1 addition & 1 deletion cpp/velox/compute/VeloxBackend.h
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class VeloxBackend {

void initJolFilesystem(const facebook::velox::Config* conf);

void printConf(const std::unordered_map<std::string, std::string>& conf);
void printConf(const facebook::velox::Config& conf);

std::string getCacheFilePrefix() {
return "cache." + boost::lexical_cast<std::string>(boost::uuids::random_generator()()) + ".";
Expand Down

0 comments on commit 36c9208

Please sign in to comment.