Skip to content

Commit

Permalink
[VL] Revert "[VL] Minor fix for CI" (#4230)
Browse files Browse the repository at this point in the history
  • Loading branch information
zhztheplayer authored Dec 29, 2023
1 parent 93e2008 commit 385b252
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 15 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ch_code_style.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
name: CH Backend Code style checks

on:
pull_request_target
pull_request

concurrency:
group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/code_style.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
name: Code style checks

on:
pull_request_target
pull_request

concurrency:
group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/velox_be.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
name: Velox backend

on:
pull_request_target:
pull_request:
paths:
- '.github/**'
- 'pom.xml'
Expand All @@ -38,10 +38,10 @@ on:
# - 'substrait/substrait-spark/**'

env:
HTTP_PROXY_HOST: ${{ secrets.SHR_IL_HTTP_PROXY_HOST }}
HTTP_PROXY_PORT: ${{ secrets.SHR_IL_HTTP_PROXY_PORT }}
DOCKER_REGISTRY_HOST: ${{ secrets.SHR_IL_DOCKER_REGISTRY_HOST }}
DOCKER_REGISTRY_PORT: ${{ secrets.SHR_IL_DOCKER_REGISTRY_PORT }}
HTTP_PROXY_HOST: 10.240.252.16
HTTP_PROXY_PORT: 911
DOCKER_REGISTRY_HOST: 10.0.2.4
DOCKER_REGISTRY_PORT: 5000

concurrency:
group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/velox_tpch_bench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ on:
types: [created, edited, deleted]

env:
JENKINS_HOST: ${{ secrets.SHR_IL_JENKINS_HOST }}
JENKINS_PORT: ${{ secrets.SHR_IL_JENKINS_PORT }}
JENKINS_USER: ${{ secrets.SHR_IL_JENKINS_USER }}
JENKINS_HOST: 10.0.0.68
JENKINS_PORT: 8080
JENKINS_USER: jenkins:11fd1b5a82bfd638bd9b3749c96b324ff2

jobs:
velox-trigger-benchmark-on-comment:
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/velox_tpch_merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
name: Velox backend Performance Tests on Merge

on:
pull_request_target:
pull_request:
types: [ closed ]
branches:
- main
Expand All @@ -39,9 +39,9 @@ on:
- 'dev/**'

env:
JENKINS_HOST: ${{ secrets.SHR_IL_JENKINS_HOST }}
JENKINS_PORT: ${{ secrets.SHR_IL_JENKINS_PORT }}
JENKINS_USER: ${{ secrets.SHR_IL_JENKINS_USER }}
JENKINS_HOST: 10.0.0.68
JENKINS_PORT: 8080
JENKINS_USER: jenkins:11fd1b5a82bfd638bd9b3749c96b324ff2

jobs:
velox-trigger-benchmark:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ class GlutenDataSourceV2Suite extends DataSourceV2Suite with GlutenSQLTestsBaseT
).foreach {
cls =>
withClue(cls.getName) {
// we test report ordering (together with report partitioning) with these transformations:
// we test report ordering (together with report partitioning) with these
// transformations:
// - groupBy("i").flatMapGroups:
// hash-partitions by "i" and sorts each partition by "i"
// requires partitioning and sort by "i"
Expand Down

0 comments on commit 385b252

Please sign in to comment.