Remove commented code

apache · Aug 20, 2024 · 42ffa7c · 42ffa7c
1 parent 522b083
commit 42ffa7c
Showing 1 changed file with 0 additions and 65 deletions.
diff --git a/.github/workflows/velox_docker.yml b/.github/workflows/velox_docker.yml
@@ -63,8 +63,6 @@ jobs:
         with:
           path: |
             ./cpp/build/releases/
-#            ./cpp/build/velox/udf/examples/
-#            ./cpp/build/velox/benchmarks/
           key: cache-velox-build-centos-7-${{ hashFiles('./cache-key') }}
       - name: Build Gluten native libraries
         if: ${{ steps.cache.outputs.cache-hit != 'true' }}
@@ -76,14 +74,6 @@ jobs:
         with:
           name: velox-native-lib-centos-7-${{github.sha}}
           path: ./cpp/build/releases/
-#      - uses: actions/upload-artifact@v2
-#        with:
-#          name: udf-example-lib-centos-7-${{github.sha}}
-#          path: ./cpp/build/velox/udf/examples/
-#      - uses: actions/upload-artifact@v2
-#        with:
-#          name: benchmark-centos-7-${{github.sha}}
-#          path: ./cpp/build/velox/benchmarks/
       - uses: actions/upload-artifact@v2
         with:
           name: arrow-jars-centos-7-${{github.sha}}
@@ -630,22 +620,6 @@ jobs:
           # Depends on --build_example=ON.
           $MVN_CMD test -Pspark-3.5 -Pbackends-velox -Piceberg -Pdelta -DtagsToExclude=None \
           -DtagsToInclude=org.apache.gluten.tags.UDFTest
-#      - uses: actions/upload-artifact@v2
-#        with:
-#          name: velox-native-lib-centos-8-${{github.sha}}
-#          path: ./cpp/build/releases/
-#      - uses: actions/upload-artifact@v2
-#        with:
-#          name: udf-example-lib-centos-8-${{github.sha}}
-#          path: ./cpp/build/velox/udf/examples/
-#      - uses: actions/upload-artifact@v2
-#        with:
-#          name: benchmark-centos-8-${{github.sha}}
-#          path: ./cpp/build/velox/benchmarks/
-#      - uses: actions/upload-artifact@v2
-#        with:
-#          name: arrow-jars-centos-8-${{github.sha}}
-#          path: /root/.m2/repository/org/apache/arrow/
 
   run-spark-test-spark32:
     needs: build-native-lib-centos-7
@@ -659,14 +633,6 @@ jobs:
         with:
           name: velox-native-lib-centos-7-${{github.sha}}
           path: ./cpp/build/releases
-#      - uses: actions/download-artifact@v2
-#        with:
-#          name: udf-example-lib-centos-7-${{github.sha}}
-#          path: ./cpp/build/velox/udf/examples/
-#      - uses: actions/download-artifact@v2
-#        with:
-#          name: benchmark-centos-7-${{github.sha}}
-#          path: ./cpp/build/velox/benchmarks/
       - uses: actions/download-artifact@v2
         with:
           name: arrow-jars-centos-7-${{github.sha}}
@@ -716,19 +682,12 @@ jobs:
           $MVN_CMD clean install -Pspark-3.2 -Pspark-ut -Pbackends-velox -Pceleborn -Piceberg \
           -Pdelta -DargLine="-Dspark.test.home=$GITHUB_WORKSPACE//shims/spark32/spark_home/" \
           -DtagsToExclude=org.apache.spark.tags.ExtendedSQLTest,org.apache.gluten.tags.UDFTest,org.apache.gluten.tags.SkipTestTags
-#          $MVN_CMD test -Pspark-3.2 -Pbackends-velox -Piceberg -Pdelta -DtagsToExclude=None -DtagsToInclude=org.apache.gluten.tags.UDFTest
       - name: Upload golden files
         if: failure()
         uses: actions/upload-artifact@v4
         with:
           name: golden-files-spark32
           path: /tmp/tpch-approved-plan/**
-#      - name: Gluten CPP Benchmark Test
-#        run: |
-#          # This test depends on example.json generated by the above mvn test.
-#          cd $GITHUB_WORKSPACE/cpp/build/velox/benchmarks && \
-#          sudo chmod +x ./generic_benchmark && \
-#          ./generic_benchmark --run-example --with-shuffle --threads 1 --iterations 1
 
   run-spark-test-spark32-slow:
     needs: build-native-lib-centos-7
@@ -793,11 +752,6 @@ jobs:
         with:
           name: velox-native-lib-centos-7-${{github.sha}}
           path: ./cpp/build/releases
-#      - name: Download UDF Example Lib
-#        uses: actions/download-artifact@v2
-#        with:
-#          name: udf-example-lib-centos-7-${{github.sha}}
-#          path: ./cpp/build/velox/udf/examples/
       - name: Download Arrow Jars
         uses: actions/download-artifact@v2
         with:
@@ -848,7 +802,6 @@ jobs:
           $MVN_CMD clean install -Pspark-3.3 -Pbackends-velox -Pceleborn -Piceberg -Pdelta -Pspark-ut \
           -DargLine="-Dspark.test.home=$GITHUB_WORKSPACE//shims/spark33/spark_home/" \
           -DtagsToExclude=org.apache.spark.tags.ExtendedSQLTest,org.apache.gluten.tags.UDFTest,org.apache.gluten.tags.SkipTestTags
-#          $MVN_CMD test -Pspark-3.3 -Pbackends-velox -Piceberg -Pdelta -DtagsToExclude=None -DtagsToInclude=org.apache.gluten.tags.UDFTest
       - name: Upload golden files
         if: failure()
         uses: actions/upload-artifact@v4
@@ -922,11 +875,6 @@ jobs:
         with:
           name: velox-native-lib-centos-7-${{github.sha}}
           path: ./cpp/build/releases
-#      - name: Download UDF Example Lib
-#        uses: actions/download-artifact@v2
-#        with:
-#          name: udf-example-lib-centos-7-${{github.sha}}
-#          path: ./cpp/build/velox/udf/examples/
       - name: Download Arrow Jars
         uses: actions/download-artifact@v2
         with:
@@ -977,7 +925,6 @@ jobs:
           $MVN_CMD clean install -Pspark-3.4 -Pbackends-velox -Pceleborn -Piceberg -Pdelta -Pspark-ut \
           -DargLine="-Dspark.test.home=$GITHUB_WORKSPACE//shims/spark34/spark_home/" \
           -DtagsToExclude=org.apache.spark.tags.ExtendedSQLTest,org.apache.gluten.tags.UDFTest,org.apache.gluten.tags.SkipTestTags
-#          $MVN_CMD test -Pspark-3.4 -Pbackends-velox -Piceberg -Pdelta -DtagsToExclude=None -DtagsToInclude=org.apache.gluten.tags.UDFTest
       - name: Upload golden files
         if: failure()
         uses: actions/upload-artifact@v4
@@ -1051,11 +998,6 @@ jobs:
         with:
           name: velox-native-lib-centos-7-${{github.sha}}
           path: ./cpp/build/releases
-#      - name: Download UDF Example Lib
-#        uses: actions/download-artifact@v2
-#        with:
-#          name: udf-example-lib-centos-7-${{github.sha}}
-#          path: ./cpp/build/velox/udf/examples/
       - name: Download Arrow Jars
         uses: actions/download-artifact@v2
         with:
@@ -1106,7 +1048,6 @@ jobs:
           $MVN_CMD clean install -Pspark-3.5 -Pbackends-velox -Pceleborn -Piceberg -Pdelta -Pspark-ut \
           -DargLine="-Dspark.test.home=$GITHUB_WORKSPACE//shims/spark35/spark_home/" \
           -DtagsToExclude=org.apache.spark.tags.ExtendedSQLTest,org.apache.gluten.tags.UDFTest,org.apache.gluten.tags.SkipTestTags
-#          $MVN_CMD test -Pspark-3.5 -Pbackends-velox -Piceberg -Pdelta -DtagsToExclude=None -DtagsToInclude=org.apache.gluten.tags.UDFTest
       - name: Upload golden files
         if: failure()
         uses: actions/upload-artifact@v4
@@ -1127,11 +1068,6 @@ jobs:
         with:
           name: velox-native-lib-centos-7-${{github.sha}}
           path: ./cpp/build/releases
-#      - name: Download UDF Example Lib
-#        uses: actions/download-artifact@v2
-#        with:
-#          name: udf-example-lib-centos-7-${{github.sha}}
-#          path: ./cpp/build/velox/udf/examples/
       - name: Download Arrow Jars
         uses: actions/download-artifact@v2
         with:
@@ -1182,7 +1118,6 @@ jobs:
           $MVN_CMD clean install -Pspark-3.5 -Pscala-2.13 -Pbackends-velox -Pceleborn -Piceberg \
           -Pdelta -Pspark-ut -DargLine="-Dspark.test.home=$GITHUB_WORKSPACE//shims/spark35/spark_home/" \
           -DtagsToExclude=org.apache.spark.tags.ExtendedSQLTest,org.apache.gluten.tags.UDFTest,org.apache.gluten.tags.SkipTestTags
-#          $MVN_CMD test -Pspark-3.5 -Pscala-2.13 -Pbackends-velox -Piceberg -Pdelta -DtagsToExclude=None -DtagsToInclude=org.apache.gluten.tags.UDFTest
 
   run-spark-test-spark35-slow:
     needs: build-native-lib-centos-7