Skip to content

Commit

Permalink
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20240823) (#6984)
Browse files Browse the repository at this point in the history
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240823)

* Fix Build due to ClickHouse/ClickHouse#68534

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang Chen <[email protected]>
  • Loading branch information
3 people authored Aug 23, 2024
1 parent 7dfd620 commit 433b439
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions cpp-ch/clickhouse.version
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
CH_ORG=Kyligence
CH_BRANCH=rebase_ch/20240822
CH_COMMIT=85d3b05e9e2
CH_BRANCH=rebase_ch/20240823
CH_COMMIT=8532edf7d75
6 changes: 3 additions & 3 deletions cpp-ch/local-engine/Functions/SparkFunctionGetJsonObject.h
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ class GetJsonObjectImpl
public:
using Element = typename JSONParser::Element;

static DB::DataTypePtr getReturnType(const char *, const DB::ColumnsWithTypeAndName &, const DB::ContextPtr &)
static DB::DataTypePtr getReturnType(const char *, const DB::ColumnsWithTypeAndName &, bool )
{
auto nested_type = std::make_shared<DB::DataTypeString>();
return std::make_shared<DB::DataTypeNullable>(nested_type);
Expand All @@ -81,7 +81,7 @@ class GetJsonObjectImpl
static size_t getNumberOfIndexArguments(const DB::ColumnsWithTypeAndName & arguments) { return arguments.size() - 1; }

bool insertResultToColumn(
DB::IColumn & dest, const Element & root, DB::GeneratorJSONPath<JSONParser> & generator_json_path, const DB::ContextPtr &)
DB::IColumn & dest, const Element & root, DB::GeneratorJSONPath<JSONParser> & generator_json_path, bool )
{
Element current_element = root;
DB::VisitorStatus status;
Expand Down Expand Up @@ -353,7 +353,7 @@ class FlattenJSONStringOnRequiredFunction : public DB::IFunction
for (size_t j = 0; j < tuple_size; ++j)
{
generator_json_paths[j]->reinitialize();
if (!impl.insertResultToColumn(*tuple_columns[j], document, *generator_json_paths[j], context))
if (!impl.insertResultToColumn(*tuple_columns[j], document, *generator_json_paths[j], true))
{
tuple_columns[j]->insertDefault();
}
Expand Down

0 comments on commit 433b439

Please sign in to comment.