Skip to content

Commit

Permalink
[WIP][VL] Support celeborn sort based shuffle
Browse files Browse the repository at this point in the history
  • Loading branch information
kerwin-zk committed May 14, 2024
1 parent 81987a7 commit 56a447f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
8 changes: 3 additions & 5 deletions cpp/velox/shuffle/VeloxSortBasedShuffleWriter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@ arrow::Result<std::shared_ptr<VeloxSortBasedShuffleWriter>> VeloxSortBasedShuffl
ShuffleWriterOptions options,
std::shared_ptr<facebook::velox::memory::MemoryPool> veloxPool,
arrow::MemoryPool* arrowPool) {
std::shared_ptr<VeloxSortBasedShuffleWriter> res(
new VeloxSortBasedShuffleWriter(numPartitions, std::move(partitionWriter), std::move(options), veloxPool, arrowPool));
std::shared_ptr<VeloxSortBasedShuffleWriter> res(new VeloxSortBasedShuffleWriter(
numPartitions, std::move(partitionWriter), std::move(options), veloxPool, arrowPool));
RETURN_NOT_OK(res->init());
return res;
} // namespace gluten
Expand Down Expand Up @@ -307,9 +307,7 @@ arrow::Status VeloxSortBasedShuffleWriter::initFromRowVector(const facebook::vel
false, facebook::velox::common::stringToCompressionKind(partitionWriter_->options().compressionTypeStr)};
batch_ = std::make_unique<facebook::velox::VectorStreamGroup>(veloxPool_.get());
batch_->createStreamTree(
std::static_pointer_cast<const facebook::velox::RowType>(rowType_.value()),
options_.bufferSize,
&serdeOptions_);
std::static_pointer_cast<const facebook::velox::RowType>(rowType_.value()), options_.bufferSize, &serdeOptions_);
return arrow::Status::OK();
}

Expand Down
1 change: 0 additions & 1 deletion cpp/velox/shuffle/VeloxSortBasedShuffleWriter.h
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ struct BinaryArrayResizeState {
};

class VeloxSortBasedShuffleWriter : public ShuffleWriter {

public:
static arrow::Result<std::shared_ptr<VeloxSortBasedShuffleWriter>> create(
uint32_t numPartitions,
Expand Down

0 comments on commit 56a447f

Please sign in to comment.