Skip to content

Commit

Permalink
[VL] Remove redundant hash function in substrait function validation
Browse files Browse the repository at this point in the history
  • Loading branch information
jinchengchenghh committed Aug 2, 2024
1 parent 807d9f7 commit 5ea8a40
Showing 1 changed file with 2 additions and 12 deletions.
14 changes: 2 additions & 12 deletions cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ static const std::unordered_set<std::string> kBlackList = {
"trunc",
"sequence",
"approx_percentile",
"get_array_struct_fields"};
"get_array_struct_fields",
"map_from_arrays"};

} // namespace

Expand Down Expand Up @@ -189,9 +190,6 @@ bool SubstraitToVeloxPlanValidator::validateScalarFunction(
return validateRound(scalarFunction, inputType);
} else if (name == "extract") {
return validateExtractExpr(params);
} else if (name == "map_from_arrays") {
LOG_VALIDATION_MSG("map_from_arrays is not supported.");
return false;
} else if (name == "concat") {
for (const auto& type : types) {
if (type.find("struct") != std::string::npos || type.find("map") != std::string::npos ||
Expand All @@ -200,14 +198,6 @@ bool SubstraitToVeloxPlanValidator::validateScalarFunction(
return false;
}
}
} else if (name == "murmur3hash") {
for (const auto& type : types) {
if (type.find("struct") != std::string::npos || type.find("map") != std::string::npos ||
type.find("list") != std::string::npos) {
LOG_VALIDATION_MSG(type + " is not supported in murmur3hash.");
return false;
}
}
}

// Validate regex functions.
Expand Down

0 comments on commit 5ea8a40

Please sign in to comment.