Skip to content

Commit

Permalink
add some comments in ReadSplit
Browse files Browse the repository at this point in the history
  • Loading branch information
liujiayi771 committed Nov 16, 2023
1 parent e58cf93 commit 5ef217e
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,10 @@
import com.google.protobuf.StringValue;
import io.substrait.proto.ReadRel;

import java.io.Serializable;
import java.util.ArrayList;
import java.util.List;

public class ExtensionTableNode implements ReadSplit, Serializable {
public class ExtensionTableNode implements ReadSplit {
private static final String MERGE_TREE = "MergeTree;";
private Long minPartsNum;
private Long maxPartsNum;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,11 @@
import org.apache.spark.sql.types.StructField;
import org.apache.spark.sql.types.StructType;

import java.io.Serializable;
import java.util.ArrayList;
import java.util.List;
import java.util.Map;

public class LocalFilesNode implements ReadSplit, Serializable {
public class LocalFilesNode implements ReadSplit {
private final Integer index;
private final List<String> paths = new ArrayList<>();
private final List<Long> starts = new ArrayList<>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,16 @@

import com.google.protobuf.MessageOrBuilder;

import java.io.Serializable;
import java.util.List;

public interface ReadSplit {
/**
* A serializable representation of a read split for native engine, including the file path and
* other information of the scan table. It is returned by {@link
* io.glutenproject.execution.BasicScanExecTransformer#getReadSplits()}.
*/
public interface ReadSplit extends Serializable {
/** The preferred locations where the table files returned by this read split can run faster. */
List<String> preferredLocations();

MessageOrBuilder toProtobuf();
Expand Down

0 comments on commit 5ef217e

Please sign in to comment.