Skip to content

Commit

Permalink
A little bit of refactoring so the test args are present if needed (e…
Browse files Browse the repository at this point in the history
….g. Java 11 & 17) but ignored if not supported (e.g Java 8).
  • Loading branch information
holdenk committed Jan 17, 2024
1 parent 725d98c commit 69c9fd2
Showing 1 changed file with 22 additions and 1 deletion.
23 changes: 22 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,27 @@
*/
</spotless.license.header>

<!-- SPARK-36796 for JDK-17 test-->
<extraJavaTestArgs>
-XX:+IgnoreUnrecognizedVMOptions
--add-opens=java.base/java.lang=ALL-UNNAMED
--add-opens=java.base/java.lang.invoke=ALL-UNNAMED
--add-opens=java.base/java.lang.reflect=ALL-UNNAMED
--add-opens=java.base/java.io=ALL-UNNAMED
--add-opens=java.base/java.net=ALL-UNNAMED
--add-opens=java.base/java.nio=ALL-UNNAMED
--add-opens=java.base/java.util=ALL-UNNAMED
--add-opens=java.base/java.util.concurrent=ALL-UNNAMED
--add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED
--add-opens=java.base/sun.nio.ch=ALL-UNNAMED
--add-opens=java.base/sun.nio.cs=ALL-UNNAMED
--add-opens=java.base/sun.security.action=ALL-UNNAMED
--add-opens=java.base/sun.util.calendar=ALL-UNNAMED
--add-opens java.base/jdk.internal.misc=ALL-UNNAMED
-Djdk.reflect.useDirectMethodHandle=false
-Dio.netty.tryReflectionSetAccessible=true
</extraJavaTestArgs>

<!-- plugin version-->
<build-helper-maven-plugin.version>3.2.0</build-helper-maven-plugin.version>
<scala.compiler.version>4.8.0</scala.compiler.version>
Expand Down Expand Up @@ -581,7 +602,7 @@
<configuration>
<testFailureIgnore>false</testFailureIgnore>
<junitxml>.</junitxml>
<argLine>-ea --add-opens java.base/jdk.internal.misc=ALL-UNNAMED --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED -Djdk.reflect.useDirectMethodHandle=false --add-opens=java.base/java.lang.reflect=ALL-UNNAMED -Dio.netty.tryReflectionSetAccessible=true -Dglutten.package.jar=${glutten.package.jar}</argLine>
<argLine>-ea ${extraJavaTestArgs} -Dglutten.package.jar=${glutten.package.jar}</argLine>
<environmentVariables>
<GLUTTEN_PACKAGE_JAR>${glutten.package.jar}</GLUTTEN_PACKAGE_JAR>
</environmentVariables>
Expand Down

0 comments on commit 69c9fd2

Please sign in to comment.