fix 5981. make result be null when the feild is null

apache · Jun 7, 2024 · 6cc104c · 6cc104c
1 parent c23d28d
commit 6cc104c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/...clickhouse/src/test/scala/org/apache/gluten/execution/GlutenClickhouseFunctionSuite.scala b/...clickhouse/src/test/scala/org/apache/gluten/execution/GlutenClickhouseFunctionSuite.scala
@@ -179,4 +179,15 @@ class GlutenClickhouseFunctionSuite extends GlutenClickHouseTPCHAbstractSuite {
         |""".stripMargin
     )(df => checkFallbackOperators(df, 0))
   }
+
+  test("GLUTEN-5981 null value from get_json_object") {
+    spark.sql("create table json_t1 (a string) using parquet")
+    spark.sql("insert into json_t1 values ('{\"a\":null}')")
+    runQueryAndCompare(
+      """
+        |SELECT get_json_object(a, '$.a') is null from json_t1
+        |""".stripMargin
+    )(df => checkFallbackOperators(df, 0))
+    spark.sql("drop table json_t1")
+  }
 }
diff --git a/cpp-ch/local-engine/Functions/SparkFunctionGetJsonObject.h b/cpp-ch/local-engine/Functions/SparkFunctionGetJsonObject.h
@@ -113,6 +113,8 @@ class GetJsonObjectImpl
         JSONStringSerializer serializer(*col_str);
         if (elements.size() == 1) [[likely]]
         {
+            if (elements[0].isNull())
+                return false;
             nullable_col_str.getNullMapData().push_back(0);
             if (elements[0].isString())
             {