Skip to content

Commit

Permalink
Found a few more renames.
Browse files Browse the repository at this point in the history
  • Loading branch information
EpsilonPrime committed Aug 23, 2024
1 parent e47529c commit 6ce90e0
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ object JoinTypeTransform {
if (!buildRight) {
throw new IllegalArgumentException("LeftAnti join should not switch children")
}
JoinRel.JoinType.JOIN_TYPE_ANTI
JoinRel.JoinType.JOIN_TYPE_LEFT_ANTI
case _ =>
// TODO: Support cross join with Cross Rel
JoinRel.JoinType.UNRECOGNIZED
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ case class ShuffledHashJoinExecTransformer(
JoinRel.JoinType.JOIN_TYPE_LEFT_SEMI
}
case LeftAnti =>
JoinRel.JoinType.JOIN_TYPE_ANTI
JoinRel.JoinType.JOIN_TYPE_LEFT_ANTI
case _ =>
JoinRel.JoinType.UNRECOGNIZED
}
Expand Down Expand Up @@ -112,7 +112,7 @@ case class BroadcastHashJoinExecTransformer(
case LeftSemi | ExistenceJoin(_) =>
JoinRel.JoinType.JOIN_TYPE_LEFT_SEMI
case LeftAnti =>
JoinRel.JoinType.JOIN_TYPE_ANTI
JoinRel.JoinType.JOIN_TYPE_LEFT_ANTI
case _ =>
// TODO: Support cross join with Cross Rel
JoinRel.JoinType.UNRECOGNIZED
Expand Down
2 changes: 1 addition & 1 deletion cpp-ch/local-engine/Common/CHUtil.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1110,7 +1110,7 @@ JoinUtil::getJoinKindAndStrictness(substrait::JoinRel_JoinType join_type, bool i
return {DB::JoinKind::Left, DB::JoinStrictness::Any};
return {DB::JoinKind::Left, DB::JoinStrictness::Semi};
}
case substrait::JoinRel_JoinType_JOIN_TYPE_ANTI:
case substrait::JoinRel_JoinType_JOIN_TYPE_LEFT_ANTI:
return {DB::JoinKind::Left, DB::JoinStrictness::Anti};
case substrait::JoinRel_JoinType_JOIN_TYPE_LEFT:
return {DB::JoinKind::Left, DB::JoinStrictness::All};
Expand Down

0 comments on commit 6ce90e0

Please sign in to comment.