avoid name collisions in naming aggregate result

apache · Aug 16, 2024 · 72cfbe8 · 72cfbe8
1 parent 5f4e558
commit 72cfbe8
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/cpp-ch/local-engine/Parser/AggregateRelParser.cpp b/cpp-ch/local-engine/Parser/AggregateRelParser.cpp
@@ -195,7 +195,7 @@ void AggregateRelParser::addPreProjection()
 
 void AggregateRelParser::buildAggregateDescriptions(AggregateDescriptions & descriptions)
 {
-    auto build_result_column_name = [](const String & function_name, const Array & params, const Strings & arg_names, substrait::AggregationPhase phase)
+    auto build_result_column_name = [this](const String & function_name, const Array & params, const Strings & arg_names, substrait::AggregationPhase phase)
     {
         if (phase == substrait::AggregationPhase::AGGREGATION_PHASE_INTERMEDIATE_TO_RESULT)
         {
@@ -219,7 +219,8 @@ void AggregateRelParser::buildAggregateDescriptions(AggregateDescriptions & desc
         result += "(";
         result += boost::algorithm::join(arg_names, ",");
         result += ")";
-        return result;
+        // Make the name unique to avoid name collision(#issue 6878).
+        return this->getUniqueName(result);
     };
 
     for (auto & agg_info : aggregates)