Skip to content

Commit

Permalink
[GLUTEN-7913][CORE] Flip dependency direction for gluten-uniffle (#8242)
Browse files Browse the repository at this point in the history
Closes #7913
  • Loading branch information
zhztheplayer authored Dec 17, 2024
1 parent c1d66c4 commit 789dd58
Show file tree
Hide file tree
Showing 10 changed files with 86 additions and 104 deletions.
19 changes: 19 additions & 0 deletions backends-velox/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,25 @@
</dependency>
</dependencies>
</profile>
<profile>
<id>uniffle</id>
<activation>
<activeByDefault>false</activeByDefault>
</activation>
<dependencies>
<dependency>
<groupId>org.apache.gluten</groupId>
<artifactId>gluten-uniffle</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.uniffle</groupId>
<artifactId>rss-client-spark${spark.major.version}-shaded</artifactId>
<version>${uniffle.version}</version>
<scope>provided</scope>
</dependency>
</dependencies>
</profile>
<profile>
<id>iceberg</id>
<activation>
Expand Down
1 change: 1 addition & 0 deletions gluten-uniffle/.gitkeep
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
The module is kept for adding common code shared by backends for Uniffle support in Gluten.
29 changes: 0 additions & 29 deletions gluten-uniffle/package/pom.xml

This file was deleted.

13 changes: 1 addition & 12 deletions gluten-uniffle/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<modelVersion>4.0.0</modelVersion>

<artifactId>gluten-uniffle</artifactId>
<packaging>pom</packaging>
<packaging>jar</packaging>
<name>Gluten Uniffle</name>

<dependencies>
Expand Down Expand Up @@ -75,15 +75,4 @@
</plugin>
</plugins>
</build>
<profiles>
<profile>
<id>backends-velox</id>
<properties>
</properties>
<modules>
<module>velox</module>
<module>package</module>
</modules>
</profile>
</profiles>
</project>
62 changes: 0 additions & 62 deletions gluten-uniffle/velox/pom.xml

This file was deleted.

2 changes: 1 addition & 1 deletion package/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
<dependencies>
<dependency>
<groupId>org.apache.gluten</groupId>
<artifactId>gluten-uniffle-package</artifactId>
<artifactId>gluten-uniffle</artifactId>
<version>${project.version}</version>
</dependency>
</dependencies>
Expand Down
64 changes: 64 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -495,6 +495,70 @@
<modules>
<module>gluten-uniffle</module>
</modules>
<build>
<plugins>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
<executions>
<execution>
<id>add-uniffle-sources</id>
<phase>generate-sources</phase>
<goals>
<goal>add-source</goal>
</goals>
<configuration>
<sources>
<source>${project.basedir}/src-uniffle/main/scala</source>
<source>${project.basedir}/src-uniffle/main/java</source>
</sources>
</configuration>
</execution>
<execution>
<id>add-uniffle-resources</id>
<phase>generate-resources</phase>
<goals>
<goal>add-resource</goal>
</goals>
<configuration>
<resources>
<resource>
<directory>${project.basedir}/src-uniffle/main/resources</directory>
</resource>
</resources>
</configuration>
</execution>
<execution>
<id>add-uniffle-test-sources</id>
<phase>generate-test-sources</phase>
<goals>
<goal>add-test-source</goal>
</goals>
<configuration>
<sources>
<source>${project.basedir}/src-uniffle/test/scala</source>
<source>${project.basedir}/src-uniffle/test/java</source>
</sources>
</configuration>
</execution>
<execution>
<id>add-uniffle-test-resources</id>
<phase>generate-test-resources</phase>
<goals>
<goal>add-test-resource</goal>
</goals>
<configuration>
<resources>
<resource>
<directory>${project.basedir}/src-uniffle/test/resources</directory>
</resource>
</resources>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
<profile>
<id>delta</id>
Expand Down

0 comments on commit 789dd58

Please sign in to comment.