Skip to content

Commit

Permalink
[VL] Allow shared dependencies for lib GCS (#8251)
Browse files Browse the repository at this point in the history
This pr simply removes the setting for CMAKE_FIND_LIBRARY_SUFFIXES before finding lib GCS. It only has impact to dynamic build (vcpkg off), no impact to static build.
  • Loading branch information
PHILO-HE authored Dec 17, 2024
1 parent ea0e175 commit 8f71966
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions cpp/velox/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,7 @@ macro(find_awssdk)
endmacro()

macro(find_gcssdk)
set(CMAKE_FIND_LIBRARY_SUFFIXES_BCK ${CMAKE_FIND_LIBRARY_SUFFIXES})
set(CMAKE_FIND_LIBRARY_SUFFIXES ".a")
find_package(google_cloud_cpp_storage CONFIG 2.22.0 REQUIRED)
set(CMAKE_FIND_LIBRARY_SUFFIXES ${CMAKE_FIND_LIBRARY_SUFFIXES_BCK})
endmacro()

macro(find_azure)
Expand Down

0 comments on commit 8f71966

Please sign in to comment.