Skip to content

Commit

Permalink
[VL] remove glog
Browse files Browse the repository at this point in the history
  • Loading branch information
jinchengchenghh committed Aug 13, 2024
1 parent 1e5a7c9 commit 9558c67
Showing 1 changed file with 1 addition and 49 deletions.
50 changes: 1 addition & 49 deletions ep/build-velox/src/modify_velox.patch
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ index 69e7f2044..777eb5ec1 100644
+
FetchContent_MakeAvailable(simdjson)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index cc180b86c..7ca6fa727 100644
index cc180b86c..50ef057f4 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -236,10 +236,15 @@ if(VELOX_ENABLE_ABFS)
Expand All @@ -130,39 +130,6 @@ index cc180b86c..7ca6fa727 100644
add_definitions(-DVELOX_ENABLE_HDFS3)
endif()

@@ -380,7 +385,7 @@ resolve_dependency(Boost 1.77.0 COMPONENTS ${BOOST_INCLUDE_LIBRARIES})
# for reference. find_package(range-v3)

set_source(gflags)
-resolve_dependency(gflags COMPONENTS ${VELOX_GFLAGS_TYPE})
+resolve_dependency(gflags)
if(NOT TARGET gflags::gflags)
# This is a bit convoluted, but we want to be able to use gflags::gflags as a
# target even when velox is built as a subproject which uses
diff --git a/velox/common/process/tests/CMakeLists.txt b/velox/common/process/tests/CMakeLists.txt
index 23ef279c2..7e4c2f2b2 100644
--- a/velox/common/process/tests/CMakeLists.txt
+++ b/velox/common/process/tests/CMakeLists.txt
@@ -24,4 +24,6 @@ target_link_libraries(
fmt::fmt
velox_time
GTest::gtest
- GTest::gtest_main)
+ GTest::gtest_main
+ glog::glog
+ gflags::gflags)
diff --git a/velox/connectors/hive/storage_adapters/abfs/RegisterAbfsFileSystem.cpp b/velox/connectors/hive/storage_adapters/abfs/RegisterAbfsFileSystem.cpp
index 5a566770f..8c2a48cc2 100644
--- a/velox/connectors/hive/storage_adapters/abfs/RegisterAbfsFileSystem.cpp
+++ b/velox/connectors/hive/storage_adapters/abfs/RegisterAbfsFileSystem.cpp
@@ -38,7 +38,6 @@ std::shared_ptr<FileSystem> abfsFileSystemGenerator(

void registerAbfsFileSystem() {
#ifdef VELOX_ENABLE_ABFS
- LOG(INFO) << "Register ABFS";
registerFileSystem(isAbfsFile, std::function(abfsFileSystemGenerator));
#endif
}
diff --git a/velox/connectors/hive/storage_adapters/hdfs/tests/HdfsMiniCluster.cpp b/velox/connectors/hive/storage_adapters/hdfs/tests/HdfsMiniCluster.cpp
index 10ee508ba..027a58ecc 100644
--- a/velox/connectors/hive/storage_adapters/hdfs/tests/HdfsMiniCluster.cpp
Expand All @@ -176,18 +143,3 @@ index 10ee508ba..027a58ecc 100644
setupEnvironment(hadoopHomeDirectory.string());
}

diff --git a/velox/dwio/parquet/writer/arrow/tests/CMakeLists.txt b/velox/dwio/parquet/writer/arrow/tests/CMakeLists.txt
index 0cda25430..b15565796 100644
--- a/velox/dwio/parquet/writer/arrow/tests/CMakeLists.txt
+++ b/velox/dwio/parquet/writer/arrow/tests/CMakeLists.txt
@@ -38,7 +38,9 @@ target_link_libraries(
GTest::gtest
GTest::gtest_main
arrow
- arrow_testing)
+ arrow_testing
+ glog::glog
+ gflags::gflags)

add_library(
velox_dwio_arrow_parquet_writer_test_lib

0 comments on commit 9558c67

Please sign in to comment.