Skip to content

Commit

Permalink
nit
Browse files Browse the repository at this point in the history
  • Loading branch information
ulysses-you committed Nov 8, 2023
1 parent 9b1f6aa commit 9b32e16
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@ case class ExpandExecTransformer(
@transient override lazy val metrics =
BackendsApiManager.getMetricsApiInstance.genExpandTransformerMetrics(sparkContext)

val originalInputAttributes: Seq[Attribute] = child.output
@transient
override lazy val references: AttributeSet =
AttributeSet(projections.flatten.flatMap(_.references))

override def metricsUpdater(): MetricsUpdater =
BackendsApiManager.getMetricsApiInstance.genExpandTransformerMetricsUpdater(metrics)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ case class SortExecTransformer(
override def requiredChildDistribution: Seq[Distribution] =
if (global) OrderedDistribution(sortOrder) :: Nil else UnspecifiedDistribution :: Nil

def getRelWithoutProject(
def getRelNode(
context: SubstraitContext,
sortOrder: Seq[SortOrder],
originalInputAttributes: Seq[Attribute],
Expand Down Expand Up @@ -92,16 +92,6 @@ case class SortExecTransformer(
}
}

def getRelNode(
context: SubstraitContext,
sortOrder: Seq[SortOrder],
originalInputAttributes: Seq[Attribute],
operatorId: Long,
input: RelNode,
validation: Boolean): RelNode = {
getRelWithoutProject(context, sortOrder, originalInputAttributes, operatorId, input, validation)
}

override protected def doValidateInternal(): ValidationResult = {
if (!BackendsApiManager.getSettings.supportSortExec()) {
return ValidationResult.notOk("Current backend does not support sort")
Expand Down

0 comments on commit 9b32e16

Please sign in to comment.