address comment to make inputfilenamereplace rule default turn off

apache · Jun 19, 2024 · 9f9da12 · 9f9da12
1 parent 9e34524
commit 9f9da12
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala b/backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala
@@ -624,9 +624,13 @@ class ScalarFunctionsValidateSuite extends FunctionsValidateTest {
   }
 
   test("Test input_file_name function") {
-    runQueryAndCompare("""SELECT input_file_name(), l_orderkey
-                         | from lineitem limit 100""".stripMargin) {
-      checkGlutenOperatorMatch[ProjectExecTransformer]
+    withSQLConf(
+      "spark.gluten.sql.enableInputFileNameReplaceRule" -> "true"
+    ) {
+      runQueryAndCompare("""SELECT input_file_name(), l_orderkey
+                           | from lineitem limit 100""".stripMargin) {
+        checkGlutenOperatorMatch[ProjectExecTransformer]
+      }
     }
   }
 

diff --git a/shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala b/shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala
@@ -752,11 +752,11 @@ object GlutenConfig {
     buildConf("spark.gluten.sql.enableInputFileNameReplaceRule")
       .internal()
       .doc(
-        "This config apply for velox backend to specify whether to enable " +
+        "Experimental: This config apply for velox backend to specify whether to enable " +
           "inputFileNameReplaceRule to support offload input_file_name " +
           "expression to native.")
       .booleanConf
-      .createWithDefault(true)
+      .createWithDefault(false)
 
   // FIXME the option currently controls both JVM and native validation against a Substrait plan.
   val NATIVE_VALIDATION_ENABLED =