support set orc timezone name

apache · Jul 26, 2024 · a188a70 · a188a70
1 parent 850e57b
commit a188a70
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/cpp-ch/local-engine/Common/CHUtil.cpp b/cpp-ch/local-engine/Common/CHUtil.cpp
@@ -770,7 +770,6 @@ void BackendInitializerUtil::initSettings(std::map<std::string, std::string> & b
     settings.set("input_format_csv_trim_whitespaces", false);
     settings.set("input_format_csv_allow_cr_end_of_line", true);
     settings.set("output_format_orc_string_as_string", true);
-    settings.set("input_format_orc_read_use_writer_time_zone", true);
     settings.set("output_format_parquet_version", "1.0");
     settings.set("output_format_parquet_compression_method", "snappy");
     settings.set("output_format_parquet_string_as_string", true);

diff --git a/cpp-ch/local-engine/Storages/SubstraitSource/ORCFormatFile.cpp b/cpp-ch/local-engine/Storages/SubstraitSource/ORCFormatFile.cpp
@@ -24,6 +24,7 @@
 #    include <Processors/Formats/Impl/ArrowBufferedStreams.h>
 #    include <Processors/Formats/Impl/NativeORCBlockInputFormat.h>
 #    include <Storages/SubstraitSource/OrcUtil.h>
+#    include <Common/CHUtil.h>
 
 namespace local_engine
 {
@@ -67,6 +68,12 @@ FormatFile::InputFormatPtr ORCFormatFile::createInputFormat(const DB::Block & he
         std::back_inserter(skip_stripe_indices));
 
     format_settings.orc.skip_stripes = std::unordered_set<int>(skip_stripe_indices.begin(), skip_stripe_indices.end());
+    if (context->getConfigRef().has("timezone"))
+    {
+        const String config_timezone = context->getConfigRef().getString("timezone");
+        const String mapped_timezone = DateTimeUtil::convertTimeZone(config_timezone);
+        format_settings.orc.reader_time_zone_name = mapped_timezone;
+    }
     auto input_format = std::make_shared<DB::NativeORCBlockInputFormat>(*file_format->read_buffer, header, format_settings);
     file_format->input = input_format;
     return file_format;