[GLUTEN-5720][VL] Enable left and right semi join type in smj (#5825)

apache · Jun 6, 2024 · a36d121 · a36d121
1 parent 54aeb01
commit a36d121
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/backends-velox/src/test/scala/org/apache/gluten/execution/TestOperator.scala b/backends-velox/src/test/scala/org/apache/gluten/execution/TestOperator.scala
@@ -1246,6 +1246,16 @@ class TestOperator extends VeloxWholeStageTransformerSuite {
         }
       }
 
+      withSQLConf("spark.gluten.sql.columnar.forceShuffledHashJoin" -> "false") {
+        runQueryAndCompare(
+          """
+            |select * from t1 left semi join t2 on t1.c1 = t2.c1 and t1.c1 > 50;
+            |""".stripMargin
+        ) {
+          checkGlutenOperatorMatch[SortMergeJoinExecTransformer]
+        }
+      }
+
       runQueryAndCompare(
         """
           |select * from t1 cross join t2;

diff --git a/cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc b/cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc
@@ -907,9 +907,11 @@ bool SubstraitToVeloxPlanValidator::validate(const ::substrait::JoinRel& joinRel
     switch (joinRel.type()) {
       case ::substrait::JoinRel_JoinType_JOIN_TYPE_INNER:
       case ::substrait::JoinRel_JoinType_JOIN_TYPE_LEFT:
+      case ::substrait::JoinRel_JoinType_JOIN_TYPE_LEFT_SEMI:
+      case ::substrait::JoinRel_JoinType_JOIN_TYPE_RIGHT_SEMI:
         break;
       default:
-        LOG_VALIDATION_MSG("Sort merge join only support inner and left join.");
+        LOG_VALIDATION_MSG("Sort merge join only support inner, left, left semi and right semi join.");
         return false;
     }
   }
@@ -923,7 +925,7 @@ bool SubstraitToVeloxPlanValidator::validate(const ::substrait::JoinRel& joinRel
     case ::substrait::JoinRel_JoinType_JOIN_TYPE_ANTI:
       break;
     default:
-      LOG_VALIDATION_MSG("Sort merge join only support inner and left join.");
+      LOG_VALIDATION_MSG("Join type is not supported: {}" + joinRel.type());
       return false;
   }