Fix build due to ClickHouse/ClickHouse#60556

apache · Jun 15, 2024 · c0de850 · c0de850
1 parent e09c4b5
commit c0de850
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/cpp-ch/local-engine/Storages/SubstraitSource/ExcelTextFormatFile.cpp b/cpp-ch/local-engine/Storages/SubstraitSource/ExcelTextFormatFile.cpp
@@ -293,7 +293,12 @@ bool ExcelTextFormatReader::readField(
         return false;
     }
 
-    if (column_size == column.size())
+    // See https://github.com/ClickHouse/ClickHouse/pull/60556
+    // In case of failing to parse, we will always push element into nullmap.
+    // so, we need using nestedColumn to check if error occurs.
+    /// FIXME:  move it to ExcelSerialization ???
+    const auto nestedColumn = DB::removeNullable(column.getPtr());
+    if (column_size == nestedColumn->size())
     {
         skipErrorChars(*buf, has_quote, maybe_quote, escape, format_settings);
         column_back_func(column);