[GLUTEN-7143][VL] RAS: Fix test case "test ignore row to columnar" wh…

…en RAS=ON (#7725)
apache · Oct 30, 2024 · c35d97e · c35d97e
1 parent 24feeed
commit c35d97e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/backends-velox/src/test/scala/org/apache/gluten/execution/FallbackSuite.scala b/backends-velox/src/test/scala/org/apache/gluten/execution/FallbackSuite.scala
@@ -233,6 +233,7 @@ class FallbackSuite extends VeloxWholeStageTransformerSuite with AdaptiveSparkPl
     Seq("true", "false").foreach {
       ignoreRowToColumnar =>
         withSQLConf(
+          GlutenConfig.RAS_ENABLED.key -> "false",
           GlutenConfig.COLUMNAR_FALLBACK_IGNORE_ROW_TO_COLUMNAR.key -> ignoreRowToColumnar,
           GlutenConfig.EXPRESSION_BLACK_LIST.key -> "collect_set",
           GlutenConfig.COLUMNAR_WHOLESTAGE_FALLBACK_THRESHOLD.key -> "1"

diff --git a/gluten-substrait/src/main/scala/org/apache/spark/sql/execution/ColumnarWriteFilesExec.scala b/gluten-substrait/src/main/scala/org/apache/spark/sql/execution/ColumnarWriteFilesExec.scala
@@ -155,7 +155,7 @@ object ColumnarWriteFilesExec {
   private val NoopTag =
     TreeNodeTag[Boolean]("org.apache.spark.sql.execution.ColumnarWriteFilesExec.NoopTag")
 
-  // Decides whether a plan not is on the dummy `WriteFilesExec + NoopLeaf` path.
+  // Decides whether a plan node is on the dummy `WriteFilesExec + NoopLeaf` path.
   object OnNoopLeafPath {
     def unapply(plan: SparkPlan): Option[NoopLeaf] = {
       val leafs = traverseDown(plan)

diff --git a/shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala b/shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala
@@ -476,7 +476,7 @@ class GlutenConfig(conf: SQLConf) extends Logging {
 object GlutenConfig {
   import SQLConf._
 
-  var GLUTEN_ENABLED_BY_DEFAULT = true
+  val GLUTEN_ENABLED_BY_DEFAULT = true
   val GLUTEN_ENABLED_KEY = "spark.gluten.enabled"
   val GLUTEN_LIB_NAME = "spark.gluten.sql.columnar.libname"
   val GLUTEN_LIB_PATH = "spark.gluten.sql.columnar.libpath"