tag

apache · Jul 8, 2024 · c631597 · c631597
1 parent 12456e5
commit c631597
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHBackend.scala b/backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHBackend.scala
@@ -300,7 +300,7 @@ object CHBackendSettings extends BackendSettingsApi with Logging {
   override def mergeTwoPhasesHashBaseAggregateIfNeed(): Boolean = true
 
   override def supportBroadcastNestedJoinJoinType: JoinType => Boolean = {
-    case _: InnerLike | LeftOuter | RightOuter | LeftSemi | FullOuter => true
+    case _: InnerLike | LeftSemi | FullOuter => true
     case _ => false
   }
 }
diff --git a/cpp-ch/local-engine/Parser/CrossRelParser.cpp b/cpp-ch/local-engine/Parser/CrossRelParser.cpp
@@ -217,7 +217,6 @@ void CrossRelParser::addPostFilter(DB::QueryPlan & query_plan, const substrait::
     {
         // It may be singular_or_list
         auto * in_node = getPlanParser()->parseExpression(actions_dag, expression);
-        auto a = isColumnConst(*in_node->column);
         filter_name = in_node->result_name;
     }
     else

diff --git a/...en-core/src/main/scala/org/apache/spark/sql/execution/ColumnarBroadcastExchangeExec.scala b/...en-core/src/main/scala/org/apache/spark/sql/execution/ColumnarBroadcastExchangeExec.scala
@@ -134,6 +134,14 @@ case class ColumnarBroadcastExchangeExec(mode: BroadcastMode, child: SparkPlan)
   }
 
   override protected def doValidateInternal(): ValidationResult = {
+//    // CH backend does not support IdentityBroadcastMode used in BNLJ
+//    if (
+//      mode == IdentityBroadcastMode && !BackendsApiManager.getSettings
+//        .supportBroadcastNestedLoopJoinExec()
+//    ) {
+//      return ValidationResult.notOk("This backend does not support IdentityBroadcastMode and BNLJ")
+//    }
+
     BackendsApiManager.getValidatorApiInstance
       .doSchemaValidate(schema)
       .map {