Skip to content

Commit

Permalink
Use VELOX_HOME instead of GLUTEN_HOME while setting ARROW_HOME
Browse files Browse the repository at this point in the history
  • Loading branch information
Surbhi-Vijay committed Nov 2, 2023
1 parent 5856426 commit c8236df
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/velox_be.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ on:
- 'shims/**'
- 'tools/gluten-it/**'
- 'tools/gluten-te/**'
- 'ep/build-arrow/**'
- 'ep/build-velox/**'
- 'cpp/*'
- 'cpp/CMake/**'
Expand Down Expand Up @@ -62,7 +61,7 @@ jobs:
run: |
docker exec ubuntu2004-test-$GITHUB_RUN_ID bash -c '
cd /opt/gluten/cpp && \
./compile.sh --build_velox_backend=ON --velox_home=/opt/velox --build_examples=ON --build_benchmarks=ON'
./compile.sh --build_velox_backend=ON --velox_home=/opt/velox --build_tests=ON --build_examples=ON --build_benchmarks=ON'
- name: Run CPP unit test
run: |
docker exec ubuntu2004-test-$GITHUB_RUN_ID bash -c 'cd /opt/gluten/cpp/build && \
Expand Down
10 changes: 4 additions & 6 deletions cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,10 @@ option(ENABLE_ORC "Enable ORC" OFF)
set(root_directory ${PROJECT_BINARY_DIR})
get_filename_component(GLUTEN_HOME ${CMAKE_SOURCE_DIR} DIRECTORY)

if (NOT DEFINED ARROW_HOME)
if (${CMAKE_BUILD_TYPE} STREQUAL "Debug")
set(ARROW_HOME ${GLUTEN_HOME}/ep/build-velox/build/velox_ep/_build/debug/third_party/arrow_ep)
else()
set(ARROW_HOME ${GLUTEN_HOME}/ep/build-velox/build/velox_ep/_build/release/third_party/arrow_ep)
endif()
if (${CMAKE_BUILD_TYPE} STREQUAL "Debug")
set(ARROW_HOME ${VELOX_HOME}/_build/debug/third_party/arrow_ep)
else()
set(ARROW_HOME ${VELOX_HOME}/_build/release/third_party/arrow_ep)
endif()

#
Expand Down

0 comments on commit c8236df

Please sign in to comment.