[VL] Do not pushdown filters with HUGEINT columns

apache · Jul 16, 2024 · cb29a58 · cb29a58
1 parent 90e0087
commit cb29a58
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/cpp/velox/substrait/SubstraitToVeloxPlan.cc b/cpp/velox/substrait/SubstraitToVeloxPlan.cc
@@ -1737,6 +1737,7 @@ void SubstraitToVeloxPlanConverter::separateFilters(
       // Check if the condition is supported to be pushed down.
       uint32_t fieldIdx;
       if (canPushdownFunction(scalarFunction, filterName, fieldIdx) &&
+	  veloxTypeList[fieldIdx]->kind() != TypeKind::HUGEINT &&
           rangeRecorders.at(fieldIdx).setCertainRangeForFunction(filterName)) {
         subfieldFunctions.emplace_back(scalarFunction);
       } else {
@@ -2141,10 +2142,7 @@ void SubstraitToVeloxPlanConverter::constructSubfieldFilters(
   bool existIsNullAndIsNotNull = filterInfo.forbidsNullSet_ && filterInfo.isNullSet_;
   uint32_t rangeSize = std::max(filterInfo.lowerBounds_.size(), filterInfo.upperBounds_.size());
 
-  if constexpr (KIND == facebook::velox::TypeKind::HUGEINT) {
-    // TODO: open it when the Velox's modification is ready.
-    VELOX_NYI("constructSubfieldFilters not support for HUGEINT type");
-  } else if constexpr (KIND == facebook::velox::TypeKind::BOOLEAN) {
+  if constexpr (KIND == facebook::velox::TypeKind::BOOLEAN) {
     // Handle bool type filters.
     // Not equal.
     if (filterInfo.notValue_) {