Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
WangGuangxin committed Aug 14, 2024
1 parent ad927fe commit df3eb3f
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions cpp/velox/substrait/SubstraitToVeloxPlan.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1614,8 +1614,10 @@ bool SubstraitToVeloxPlanConverter::canPushdownFunction(
return false;
}

// check whether data type is supported or not
if (!veloxTypeList.empty() && fieldIdx < veloxTypeList.size() && !isPushdownSupported(veloxTypeList.at(fieldIdx))) {
// Check whether data type is supported or not
if (!veloxTypeList.empty() &&
fieldIdx < veloxTypeList.size() &&
!isPushdownSupported(veloxTypeList.at(fieldIdx))) {
return false;
}

Expand Down Expand Up @@ -1696,7 +1698,7 @@ bool SubstraitToVeloxPlanConverter::canPushdownOr(
}

bool SubstraitToVeloxPlanConverter::isPushdownSupported(TypePtr inputType) {
// keep the same with mapToFilters
// Keep the same with mapToFilters
switch (inputType->kind()) {
case TypeKind::TIMESTAMP:
case TypeKind::VARBINARY:
Expand Down

0 comments on commit df3eb3f

Please sign in to comment.