Skip to content

Commit

Permalink
enable more spark 3.4 UTs
Browse files Browse the repository at this point in the history
  • Loading branch information
ayushi agarwal committed Dec 12, 2023
1 parent 8df61b2 commit f275989
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ class VeloxTestSettings extends BackendTestSettings {
"INCONSISTENT_BEHAVIOR_CROSS_VERSION: compatibility with Spark 2.4/3.2 in reading/writing dates")
.exclude("FAILED_EXECUTE_UDF: execute user defined function")
.exclude("UNRECOGNIZED_SQL_TYPE: unrecognized SQL type -100")
.exclude("INVALID_BUCKET_FILE: error if there exists any malformed bucket files")
.excludeByPrefix("SCALAR_SUBQUERY_TOO_MANY_ROWS:")
.excludeByPrefix("UNSUPPORTED_FEATURE.MULTI_ACTION_ALTER:")
enableSuite[GlutenQueryParsingErrorsSuite]
Expand Down Expand Up @@ -987,7 +986,6 @@ class VeloxTestSettings extends BackendTestSettings {
enableSuite[GlutenCountMinSketchAggQuerySuite]
enableSuite[GlutenCsvFunctionsSuite]
enableSuite[GlutenCTEHintSuite]
.exclude("Resolve join hint in CTE")
enableSuite[GlutenCTEInlineSuiteAEOff]
enableSuite[GlutenCTEInlineSuiteAEOn]
enableSuite[GlutenDataFrameAggregateSuite]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import org.apache.spark.status.ElementTrackingStore

class GlutenFallbackSuite extends GlutenSQLTestsTrait {

ignore("test fallback logging") {
test("test fallback logging") {
val testAppender = new LogAppender("fallback reason")
withLogAppender(testAppender) {
withSQLConf(
Expand All @@ -36,13 +36,13 @@ class GlutenFallbackSuite extends GlutenSQLTestsTrait {
sql("SELECT * FROM t").collect()
}
}
val msgRegex = """Validation failed for plan: Scan parquet default\.t\[QueryId=[0-9]+\],""" +
val msgRegex = """Validation failed for plan: Scan parquet spark_catalog.default\.t\[QueryId=[0-9]+\],""" +
""" due to: columnar FileScan is not enabled in FileSourceScanExec\."""
assert(testAppender.loggingEvents.exists(_.getMessage.getFormattedMessage.matches(msgRegex)))
}
}

ignore("test fallback event") {
test("test fallback event") {
val kvStore = spark.sparkContext.statusStore.store.asInstanceOf[ElementTrackingStore]
val glutenStore = new GlutenSQLAppStatusStore(kvStore)
assert(glutenStore.buildInfo().info.find(_._1 == "Gluten Version").exists(_._2 == VERSION))
Expand Down Expand Up @@ -83,7 +83,7 @@ class GlutenFallbackSuite extends GlutenSQLTestsTrait {
assert(execution.get.numGlutenNodes == 0)
assert(execution.get.numFallbackNodes == 2)
val fallbackReason = execution.get.fallbackNodeToReason.head
assert(fallbackReason._1.contains("Scan parquet default.t"))
assert(fallbackReason._1.contains("Scan parquet spark_catalog.default.t"))
assert(fallbackReason._2.contains("columnar FileScan is not enabled in FileSourceScanExec"))
}
}
Expand Down

0 comments on commit f275989

Please sign in to comment.